> On Aug. 24, 2013, 5:23 p.m., Michael Joyce wrote: > > http://svn.apache.org/repos/asf/incubator/climate/trunk/ocw/dataset.py, > > lines 52-55 > > <https://reviews.apache.org/r/13738/diff/1/?file=343842#file343842line52> > > > > +1 on the function change but why are we catching an error just so we > > can re-raise it? Why not just remove the try-except?
Good point. I will remove the try block. - Cameron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13738/#review25504 ----------------------------------------------------------- On Aug. 22, 2013, 3:15 p.m., Cameron Goodale wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13738/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2013, 3:15 p.m.) > > > Review request for Apache Open Climate and Michael Joyce. > > > Bugs: CLIMATE-274 > https://issues.apache.org/jira/browse/CLIMATE-274 > > > Repository: climate > > > Description > ------- > > I created 5 different ValueError exception error messages for each different > check we perform when a Dataset object is initialized. > > > Diffs > ----- > > http://svn.apache.org/repos/asf/incubator/climate/trunk/ocw/dataset.py > 1516193 > > Diff: https://reviews.apache.org/r/13738/diff/ > > > Testing > ------- > > I re-ran test_dataset.py and all 23 tests pass. > > > Thanks, > > Cameron Goodale > >
