-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10150/
-----------------------------------------------------------

Review request for cloudstack.


Summary (updated)
-----------------

CS 1773 seems to break build and networking.


Description (updated)
-------

4.1 compiling and network seem to have been broken by disabling baremetal in 
the code. The fix comments out the UCS bit so the client GUI doesn't break the 
build. The network service implementation breaks the deployment of VMs as 
BareMetal is still called there but it's not in the code anymore:
2013-03-26 12:46:59,302 WARN  [cloud.network.NetworkServiceImpl] 
(1572481896@qtp-789857310-7:null) Exception: 
com.cloud.exception.InvalidParameterValueException: Invalid Network Service 
Provider=BaremetalDhcpProvider
        at 
com.cloud.network.NetworkServiceImpl.addProviderToPhysicalNetwork(NetworkServiceImpl.java:2300)
        at 
com.cloud.network.NetworkServiceImpl.addDefaultBaremetalProvidersToPhysicalNetwork(NetworkServiceImpl.java:2789)
        at 
com.cloud.network.NetworkServiceImpl.createPhysicalNetwork(NetworkServiceImpl.java:1949)


This addresses bug CS-1773.


Diffs (updated)
-----

  client/pom.xml 33a2274 
  plugins/network-elements/dns-notifier/resources/components-example.xml 
36441bd 
  server/src/com/cloud/network/NetworkServiceImpl.java 0cd3ebe 

Diff: https://reviews.apache.org/r/10150/diff/


Testing (updated)
-------

Took a fresh checkout, did the changes, compiled, ran cloudmonkey and presto I 
had a couple of VMs


Thanks,

Funs Kessen

Reply via email to