> On March 29, 2013, 5:52 a.m., Prasanna Santhanam wrote: > > setup/db/create-schema.sql, line 2370 > > <https://reviews.apache.org/r/9871/diff/2/?file=275778#file275778line2370> > > > > Kawai-san, If this is applied to master, I think this section should go > > in the schema-40to410.sql, instead of create-schema. Changes to the 4.0 > > schema after the database creator was introduced shouldn't be required. > > Hiroaki Kawai wrote: > This patch was created for 4.0 branch. So where to put the sql seems to > depend on when to merge this patch. Do you think this patch should be in > master, not 4.0? If so, I'll rewrite the patch again.
That should be okay then. Since the bug exists on all versions just wanted to call out that the fix differs when applied to master, 4.1. For 4.0 this is fine. Once the server side code is reviewed master/4.1 patch can be made. Thanks - Prasanna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9871/#review18495 ----------------------------------------------------------- On March 29, 2013, 1:49 a.m., Hiroaki Kawai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9871/ > ----------------------------------------------------------- > > (Updated March 29, 2013, 1:49 a.m.) > > > Review request for cloudstack, Hugo Trippaers and Chiradeep Vittal. > > > Description > ------- > > The location of the virtual machine is provided by DeployDestination, which > will be passed in NetworkGuru#reserve and NetworkElement#prepare. > > During the virtual machine migration, it actually changes DeployDestination > and it looks like that it will tell that event to network components as it > has NetworkManager#prepareNicForMigration. The problem is that althogh the > interface has that method, NetworkManagerImpl does not tell the > DeployDestination changes to network components. > > So IMHO, we need to add calls of NetworkGuru#reserve and > NetworkElement#prepare in NetworkManagerImpl#prepareNicForMigration . And > then, we also need to add calls NetworkGuru#release and > NetworkElement#release after the migration, otherwise the network resources > that plugin reserved will be kept even when the vm leaves off. > > Created a first minimum patch to show the concept. > > > This addresses bug CLOUDSTACK-1638. > > > Diffs > ----- > > docs/en-US/plugin-niciranvp-tables.xml 4f81655 > > plugins/network-elements/nicira-nvp/src/com/cloud/network/NiciraNvpNicMappingVO.java > 0779e69 > > plugins/network-elements/nicira-nvp/src/com/cloud/network/element/NiciraNvpElement.java > 1fcccdb > server/src/com/cloud/network/NetworkManager.java 4124b19 > server/src/com/cloud/network/NetworkManagerImpl.java a98bdd4 > server/src/com/cloud/network/guru/ControlNetworkGuru.java 934cd70 > server/src/com/cloud/network/guru/DirectNetworkGuru.java ee824af > server/src/com/cloud/network/guru/DirectPodBasedNetworkGuru.java 354d7ed > server/src/com/cloud/network/guru/ExternalGuestNetworkGuru.java 24d24f8 > server/src/com/cloud/network/guru/GuestNetworkGuru.java cebfb08 > server/src/com/cloud/network/guru/PodBasedNetworkGuru.java b513325 > server/src/com/cloud/network/guru/StorageNetworkGuru.java 879d0cd > server/src/com/cloud/vm/VirtualMachineManagerImpl.java 9230f4a > setup/db/create-schema.sql 5b6dc04 > > Diff: https://reviews.apache.org/r/9871/diff/ > > > Testing > ------- > > > Thanks, > > Hiroaki Kawai > >
