Never mind, I found it in master. Chip, I'll put another patch to the same review ticket.
Kelven On 4/5/13 10:47 AM, "Kelven Yang" <kelven.y...@citrix.com> wrote: >For some reason, the diff in the ticket about your change does not show up >Nicira, MidoNet Network Guru. >On quick question to confirm, Nicira/MidoNet are supposed to be available >in non-OSS build, is that correct? > >Kelven > >On 4/5/13 5:35 AM, "Hugo Trippaers" <htrippa...@schubergphilis.com> wrote: > >>Hey Kelven, >> >>I commented on your patch on the review board. Can you modify the patch >>so all Nicira and MidoNet stuff is also in? I fixed master so you should >>be able to use that. >> >>Cheers, >> >>Hugo >> >>> -----Original Message----- >>> From: Kelven Yang [mailto:nore...@reviews.apache.org] On Behalf Of >>> Kelven Yang >>> Sent: vrijdag 5 april 2013 0:14 >>> To: Chip Childers >>> Cc: cloudstack; Kelven Yang >>> Subject: Review Request: Finalize >>> componentContext.xml/nonComponentContext.xml content organization to >>> be plugin friendly >>> >>> >>> ----------------------------------------------------------- >>> This is an automatically generated e-mail. To reply, visit: >>> https://reviews.apache.org/r/10292/ >>> ----------------------------------------------------------- >>> >>> Review request for cloudstack and Chip Childers. >>> >>> >>> Description >>> ------- >>> >>> With removal of component auto-scanning, all components are needed to >>> configure in XML files. For OSS deployment, component declarations will >>>be >>> in applicationContext.xml and componentContext.xml, for non-OSS >>> deployment, component declarations will be in applicationContext.xml >>>and >>> nonossComponentContext.xml >>> >>> OSS/non-OSS common components should all go to applicationContext.xml, >>> OSS or non-OSS specific components, or if there are OSS or non-OSS >>>specific >>> adapter configurations, they should go to componentContext.xml or >>> nonComponentContext.xml respecitively. >>> >>> If you add a big feature module, organize all components for the module >>>into >>> its own section. >>> >>> >>> This addresses bug CLOUDSTACK-1917. >>> >>> >>> Diffs >>> ----- >>> >>> client/tomcatconf/applicationContext.xml.in 17725f0 >>> client/tomcatconf/componentContext.xml.in 2a4a29f >>> client/tomcatconf/nonossComponentContext.xml.in 13004c3 >>> utils/src/com/cloud/utils/component/AdapterList.java PRE-CREATION >>> >>> Diff: https://reviews.apache.org/r/10292/diff/ >>> >>> >>> Testing >>> ------- >>> >>> manual test is done for both OSS/non-OSS >>> >>> >>> Thanks, >>> >>> Kelven Yang >> >
