> On April 5, 2013, 4:03 p.m., Chip Childers wrote: > > Is there any automated testing of this feature today? Marvin tests of the > > HTTP service? Unit tests? > > > > If not, now seems like a good time to add some. I realize you are just > > updating the size of the data field, but IMO we should strive to improve > > automated tests with everything we touch.
There probably are automated tests already for the deployvmcmd itself, and that should cover some of the functionality, for example, current GET requests should continue to work with the expanded userdata field. I will take a look though to see if more tests can be added. > On April 5, 2013, 4:03 p.m., Chip Childers wrote: > > setup/db/create-schema.sql, line 1131 > > <https://reviews.apache.org/r/10294/diff/1/?file=278165#file278165line1131> > > > > I don't believe we should be modifying create-schema.sql for this. > > See: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Database+Creator > > > > It says: "WE NEVER CHANGE schema files such as create-schema.sql" Thanks for catching that - I'll remove it. - Venkata Siva Vijayendra ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/#review18704 ----------------------------------------------------------- On April 5, 2013, 1:56 a.m., Venkata Siva Vijayendra Bhamidipati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10294/ > ----------------------------------------------------------- > > (Updated April 5, 2013, 1:56 a.m.) > > > Review request for cloudstack, Chip Childers, Hugo Trippaers, Kelven Yang, > and Min Chen. > > > Description > ------- > > Please refer to > https://cwiki.apache.org/confluence/display/CLOUDSTACK/DeployVirtualMachine+userdata+enhancements > for a background on the requirements driving this patch. > > This patch hasn't been extensively tested yet, and I will update this request > with more info. I am uploading a first diff for initial review/comments. > > > This addresses bug CLOUDSTACK-1086. > > > Diffs > ----- > > api/src/com/cloud/vm/UserVmService.java 2c33d41 > api/src/org/apache/cloudstack/api/BaseCmd.java 78a2af3 > api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 21a45f8 > core/src/com/cloud/vm/UserVmVO.java a16eaf9 > server/src/com/cloud/api/ApiDispatcher.java 925d90a > server/src/com/cloud/api/ApiServer.java d842819 > server/src/com/cloud/api/ApiServerService.java 12d8b52 > server/src/com/cloud/api/ApiServlet.java 03bfb5f > server/src/com/cloud/vm/UserVmManagerImpl.java 24bce8b > server/test/com/cloud/vm/MockUserVmManagerImpl.java dd8dd83 > setup/db/create-schema.sql b1feb02 > setup/db/db/schema-410to420.sql ab9df05 > > Diff: https://reviews.apache.org/r/10294/diff/ > > > Testing > ------- > > > Thanks, > > Venkata Siva Vijayendra Bhamidipati > >
