----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10294/ -----------------------------------------------------------
(Updated April 5, 2013, 10:22 p.m.) Review request for cloudstack, Chip Childers, Hugo Trippaers, Kelven Yang, and Min Chen. Changes ------- Removing column datatype modification in schema-create.sql. Adding a lazy fetch annotation to the user_data column in the UserVMVO class to improve read performance. Having this will cause ehcache to not read in the user_data column every time it loads in the VO object from the db. This helps especially if the userdata is 32k in size and we don't need to work with it. If we do need to access it, ehcache will pull it in dynamically. Description ------- Please refer to https://cwiki.apache.org/confluence/display/CLOUDSTACK/DeployVirtualMachine+userdata+enhancements for a background on the requirements driving this patch. This patch hasn't been extensively tested yet, and I will update this request with more info. I am uploading a first diff for initial review/comments. This addresses bug CLOUDSTACK-1086. Diffs (updated) ----- api/src/com/cloud/vm/UserVmService.java 2c33d41 api/src/org/apache/cloudstack/api/BaseCmd.java 78a2af3 api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 21a45f8 core/src/com/cloud/vm/UserVmVO.java a16eaf9 server/src/com/cloud/api/ApiDispatcher.java 925d90a server/src/com/cloud/api/ApiServer.java d842819 server/src/com/cloud/api/ApiServerService.java 12d8b52 server/src/com/cloud/api/ApiServlet.java 03bfb5f server/src/com/cloud/vm/UserVmManagerImpl.java 24bce8b server/test/com/cloud/vm/MockUserVmManagerImpl.java dd8dd83 setup/db/db/schema-410to420.sql ab9df05 Diff: https://reviews.apache.org/r/10294/diff/ Testing ------- Thanks, Venkata Siva Vijayendra Bhamidipati
