> On April 12, 2013, 5:28 a.m., Min Chen wrote: > > server/src/com/cloud/api/query/QueryManagerImpl.java, line 2111 > > <https://reviews.apache.org/r/10426/diff/1/?file=280571#file280571line2111> > > > > For domain users, they should not be able to query system offerings. > > This fix didn't guard that case.
If this patch is to fix 1989 (instead of 1987), then the patch looks fine to me. Based on ML discussion, it seems that we need to update this review summary to clarify that it is to fix CLOUDSTACK-1989. - Min ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10426/#review19052 ----------------------------------------------------------- On April 12, 2013, 4:57 a.m., Ryan Dietrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10426/ > ----------------------------------------------------------- > > (Updated April 12, 2013, 4:57 a.m.) > > > Review request for cloudstack, Chip Childers and Marcus Sorensen. > > > Description > ------- > > So, without this fix you can't query service offerings that don't have a > domain id set (null). > > > Diffs > ----- > > server/src/com/cloud/api/query/QueryManagerImpl.java 951d09e > > Diff: https://reviews.apache.org/r/10426/diff/ > > > Testing > ------- > > Called "listServiceOfferings" using a simple perl script, once with an ID, > and once without an ID specified. > > > Thanks, > > Ryan Dietrich > >
