I will provide a patch for 1987 today.

Thanks
-min

On 4/12/13 6:06 AM, "Chip Childers" <chip.child...@sungard.com> wrote:

>On Fri, Apr 12, 2013 at 05:38:28AM +0000, Min Chen wrote:
>> 
>> 
>> > On April 12, 2013, 5:28 a.m., Min Chen wrote:
>> > > server/src/com/cloud/api/query/QueryManagerImpl.java, line 2111
>> > > 
>><https://reviews.apache.org/r/10426/diff/1/?file=280571#file280571line211
>>1>
>> > >
>> > >     For domain users, they should not be able to query system
>>offerings. This fix didn't guard that case.
>> 
>> If this patch is to fix 1989 (instead of 1987), then the patch looks
>>fine to me. Based on ML discussion, it seems that we need to update this
>>review summary to clarify that it is to fix CLOUDSTACK-1989.
>
>Summary corrected, and applied.  I resolved 1989.
>
>We still need a fix for 1987

Reply via email to