----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10605/#review19389 -----------------------------------------------------------
Ship it! It looks a valid fix to me .The physical network db state updation should happen outside the if loop. I have tested it on my set up as well . I'll merge it unless anyone else thinks that there could be another fix possible . This is a blocker right now and hence needs to be fixed asap ! - Pranav Saxena On April 18, 2013, 2:40 p.m., Isaac Chiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10605/ > ----------------------------------------------------------- > > (Updated April 18, 2013, 2:40 p.m.) > > > Review request for cloudstack and Pranav Saxena. > > > Description > ------- > > The root cause of the issue is that there is only one update statement around > line 2450 in NetworkServiceImpl.java , but it is enclosed by a if statement: > > if (newVnetRangeString != null) > > so if the newVnetRangeString object equals to null > > The physical_network database won't get update. > > The patch move following line out of if block : > > _physicalNetworkDao.update(id, network); > > > This addresses bug CLOUDSTACK-2077. > > > Diffs > ----- > > server/src/com/cloud/network/NetworkServiceImpl.java 12c6068 > > Diff: https://reviews.apache.org/r/10605/diff/ > > > Testing > ------- > > Test with ui and curl command > > > Thanks, > > Isaac Chiang > >
