----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10605/#review19390 -----------------------------------------------------------
Commit 34899f9b999e0d92573aa7b8872e07a111811b53 in branch refs/heads/master from Pranav Saxena <pranav.sax...@citrix.com> [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=34899f9 ] CLOUDSTACK-2077:The updatePhysicalNetwork command fails to update the database - ASF Subversion and Git Services On April 18, 2013, 2:40 p.m., Isaac Chiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10605/ > ----------------------------------------------------------- > > (Updated April 18, 2013, 2:40 p.m.) > > > Review request for cloudstack and Pranav Saxena. > > > Description > ------- > > The root cause of the issue is that there is only one update statement around > line 2450 in NetworkServiceImpl.java , but it is enclosed by a if statement: > > if (newVnetRangeString != null) > > so if the newVnetRangeString object equals to null > > The physical_network database won't get update. > > The patch move following line out of if block : > > _physicalNetworkDao.update(id, network); > > > This addresses bug CLOUDSTACK-2077. > > > Diffs > ----- > > server/src/com/cloud/network/NetworkServiceImpl.java 12c6068 > > Diff: https://reviews.apache.org/r/10605/diff/ > > > Testing > ------- > > Test with ui and curl command > > > Thanks, > > Isaac Chiang > >
