David, In CloudStack, the domain-admin is able to list the events from his domain and from the subdomain/accounts under his domain, and prior to this fix, domain-admin was able to delete/archive the events only from his account and not from sub-domains/accounts under his domain. This fix will allow domain-admin to delete/archive events which he can see on his dashboard.
So, this fix is not changing the existing design. Please let me know your thoughts on this. --Sanjay > -----Original Message----- > From: Sanjay Tripathi [mailto:[email protected]] > Sent: Saturday, April 27, 2013 1:55 AM > To: [email protected]; David Nalley; Sateesh Chodapuneedi; Min > Chen; Devdeep Singh > Cc: cloudstack > Subject: RE: Review Request: CLOUDSTACK-1904: API : UI : Admin can not > delete Events/Archive from other accounts > > David, > > This was the intended design for the feature "Ability to delete/archive > events" and mentioned in the Functional spec: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Ability+to+delet > e+or+archive+Events+and+Alerts > This tells that root/domain admin has the privilege to delete/archive events > of accounts/sub-domains which are under his/her domain. > > --Sanjay > > > -----Original Message----- > > From: David Nalley [mailto:[email protected]] On Behalf Of > > David Nalley > > Sent: Friday, April 26, 2013 8:44 PM > > To: Sateesh Chodapuneedi; Min Chen; Devdeep Singh > > Cc: David Nalley; Sanjay Tripathi; cloudstack > > Subject: Re: Review Request: CLOUDSTACK-1904: API : UI : Admin can not > > delete Events/Archive from other accounts > > > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/10796/#review19771 > > ----------------------------------------------------------- > > > > > > Sanjay: > > > > This looks like a change in the design. Can you make sure this gets > > discussed on the list first? > > > > Thanks, > > > > --David > > > > - David Nalley > > > > > > On April 26, 2013, 11:26 a.m., Sanjay Tripathi wrote: > > > > > > ----------------------------------------------------------- > > > This is an automatically generated e-mail. To reply, visit: > > > https://reviews.apache.org/r/10796/ > > > ----------------------------------------------------------- > > > > > > (Updated April 26, 2013, 11:26 a.m.) > > > > > > > > > Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, > > and Min Chen. > > > > > > > > > Description > > > ------- > > > > > > CLOUDSTACK-1904: API : UI : Admin can not delete Events/Archive from > > other accounts. > > > > > > > > > This addresses bug CLOUDSTACK-1904. > > > > > > > > > Diffs > > > ----- > > > > > > > > > api/src/org/apache/cloudstack/api/command/user/event/DeleteEventsCmd > > .java 55ca92a > > > core/src/com/cloud/event/dao/EventDao.java da5f47a > > > core/src/com/cloud/event/dao/EventDaoImpl.java 6ba59c5 > > > server/src/com/cloud/domain/dao/DomainDao.java afeb0f4 > > > server/src/com/cloud/domain/dao/DomainDaoImpl.java c30ca5e > > > server/src/com/cloud/server/ManagementServerImpl.java 16127a2 > > > server/src/com/cloud/user/dao/AccountDao.java 3b7fa66 > > > server/src/com/cloud/user/dao/AccountDaoImpl.java 892fdcd > > > server/test/com/cloud/event/EventControlsUnitTest.java 3c25275 > > > > > > Diff: https://reviews.apache.org/r/10796/diff/ > > > > > > > > > Testing > > > ------- > > > > > > Tests: > > > 1. Create a domain. > > > 2. Create an admin account (a11) under this domain. > > > 3. Login to the domain admin account and then logout (this is to > > > generate > > login/logout events). > > > 4. Login to Root Admin account. > > > 5. Go to Events and try to delete/archive events with account=a11 > > > (domain > > admin account). > > > 6. Event got deleted and verifies the control flow of admin accounts > > > in > > CloudStack. > > > > > > > > > Thanks, > > > > > > Sanjay Tripathi > > > > > >
