----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10796/#review20473 -----------------------------------------------------------
engine/schema/src/com/cloud/domain/dao/DomainDao.java <https://reviews.apache.org/r/10796/#comment42191> Should we call this function as getDomainChildrenIds? Also consider making the return object as Set<Long>. engine/schema/src/com/cloud/domain/dao/DomainDaoImpl.java <https://reviews.apache.org/r/10796/#comment42192> The camel notation on this looks incorrect. Should it be FindIdsOfAllChildrenSearch? engine/schema/src/com/cloud/event/dao/EventDaoImpl.java <https://reviews.apache.org/r/10796/#comment42193> Does it need both, a null check and an empty check? engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java <https://reviews.apache.org/r/10796/#comment42195> Nitpick, should we call it domainIds since we are querying based on domain id of the account? server/src/com/cloud/server/ManagementServerImpl.java <https://reviews.apache.org/r/10796/#comment42196> Why do we have to add the domain Id to the list? Won't the query below not return this domainId in the result? server/src/com/cloud/server/ManagementServerImpl.java <https://reviews.apache.org/r/10796/#comment42197> Same comment as above. Do we need to explicitly add the domainId to the list? - Devdeep Singh On May 7, 2013, 10:37 a.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10796/ > ----------------------------------------------------------- > > (Updated May 7, 2013, 10:37 a.m.) > > > Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min > Chen. > > > Description > ------- > > CLOUDSTACK-1904: API : UI : Admin can not delete Events/Archive from other > accounts. > > > This addresses bug CLOUDSTACK-1904. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/command/user/event/DeleteEventsCmd.java > 55ca92a > engine/schema/src/com/cloud/domain/dao/DomainDao.java afeb0f4 > engine/schema/src/com/cloud/domain/dao/DomainDaoImpl.java c30ca5e > engine/schema/src/com/cloud/event/dao/EventDao.java da5f47a > engine/schema/src/com/cloud/event/dao/EventDaoImpl.java 6ba59c5 > engine/schema/src/com/cloud/user/dao/AccountDao.java 3b7fa66 > engine/schema/src/com/cloud/user/dao/AccountDaoImpl.java 892fdcd > server/src/com/cloud/server/ManagementServerImpl.java da8f30e > server/test/com/cloud/event/EventControlsUnitTest.java 3c25275 > > Diff: https://reviews.apache.org/r/10796/diff/ > > > Testing > ------- > > Tests: > 1. Create a domain. > 2. Create an admin account (a11) under this domain. > 3. Login to the domain admin account and then logout (this is to generate > login/logout events). > 4. Login to Root Admin account. > 5. Go to Events and try to delete/archive events with account=a11 (domain > admin account). > 6. Event got deleted and verifies the control flow of admin accounts in > CloudStack. > > > Thanks, > > Sanjay Tripathi > >
