On 07/05/13 5:23 PM, "Daan Hoogland" <dhoogl...@schubergphilis.com> wrote:
>LS, > >I want to refactor the network guru hierarchy to put som functionality in >abstract base classes. This will come down to extending the hierarchy for >guest networks to include all gurus. Are there any thoughts or gotchas to >share? GuestNetworkGuru in some sense already acting as abstract base class, except for the fact that it is tied to 'Vlan' isolation. We can generalise the 'GuestNetworkGuru' and let the isolation type specific network design aspects to concrete classes. Other gurus (direct, pod based) for guest networks does not have any extensions at this point and does not overlap much with GuestNetworkGuru, so they may remain as is. Are there any specify observations that you think refactor will address? > >This would be the second part of a three stage strategy I have to support >creating a nicira hosted private gateway for vpcs. >The first one is making sure vlans are specified as uri throughout the >system. I will be submitting a patch for review for this part soon. >The last part will be creating a guru based on Hugo's >NiciraNvpGuestNetworkGuru. > >Any comment is appreciated, >Daan Hoogland >
