> On April 29, 2013, 8:30 a.m., Prasanna Santhanam wrote:
> > test/integration/component/test_cpu_limits.py, line 527
> > <https://reviews.apache.org/r/10828/diff/1/?file=285303#file285303line527>
> >
> >     There's some confusion I have here:
> >     
> >     1. you are using the apiClient of the admin role and the limits apply 
> > on the account (domadmin, chlilddomadmin) 
> >     2. use the api client of the account you created instead to establish 
> > the limits? createUserApiClient from marvin's library can be used here.
> >

Hi Prasanna, are you suggesting this change while updating limits for an 
account or creating an instance with the account?

In both the methods we are passing the account id and respective domain id for 
which we are updating limits/creating account within. Also, will creating new 
api client of that account make difference in this case as we are already 
specifying account and domain id?


- Gaurav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10828/#review19846
-----------------------------------------------------------


On April 29, 2013, 8:36 a.m., Chirag Jog wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10828/
> -----------------------------------------------------------
> 
> (Updated April 29, 2013, 8:36 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam, sailaja mada, and Girish 
> Shilamkar.
> 
> 
> Description
> -------
> 
> Here is the detailed test plan: 
> https://issues.apache.org/jira/secure/attachment/12571551/LimitResourcesTestPlan1.xlsx
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1466.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_cpu_limits.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/10828/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chirag Jog
> 
>

Reply via email to