> On April 29, 2013, 8:30 a.m., Prasanna Santhanam wrote: > > test/integration/component/test_cpu_limits.py, line 417 > > <https://reviews.apache.org/r/10828/diff/1/?file=285303#file285303line417> > > > > method name doesn't reflect intent. you are doing a checkResourceCount > > but doing an updateCount within? Was this intended?
Here we are checking the updated resource count. Will Change method name to "checkUpdatedResourceCount" to avoid confusion. - Gaurav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10828/#review19846 ----------------------------------------------------------- On April 29, 2013, 8:36 a.m., Chirag Jog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10828/ > ----------------------------------------------------------- > > (Updated April 29, 2013, 8:36 a.m.) > > > Review request for cloudstack, Prasanna Santhanam, sailaja mada, and Girish > Shilamkar. > > > Description > ------- > > Here is the detailed test plan: > https://issues.apache.org/jira/secure/attachment/12571551/LimitResourcesTestPlan1.xlsx > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1466. > > > Diffs > ----- > > test/integration/component/test_cpu_limits.py PRE-CREATION > > Diff: https://reviews.apache.org/r/10828/diff/ > > > Testing > ------- > > > Thanks, > > Chirag Jog > >
