> On June 11, 2013, 5:22 a.m., Koushik Das wrote: > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java, line 3083 > > <https://reviews.apache.org/r/11435/diff/2/?file=299906#file299906line3083> > > > > if result_final == false, why is txn committed?
i missed the txn.rollback here, the txn.commit is okay. - bharat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11435/#review21692 ----------------------------------------------------------- On June 3, 2013, 10:27 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11435/ > ----------------------------------------------------------- > > (Updated June 3, 2013, 10:27 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Koushik Das. > > > Description > ------- > > [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C > https://issues.apache.org/jira/browse/CLOUDSTACK-2621 > > > This addresses bug Cloudstack-2621. > > > Diffs > ----- > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > c71d037 > > Diff: https://reviews.apache.org/r/11435/diff/ > > > Testing > ------- > > tested on master. > > > Thanks, > > bharat kumar > >
