----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11435/#review21700 -----------------------------------------------------------
server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/11435/#comment44863> why not pass the 'caller' parameter to handleIpAliasDelete? server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/11435/#comment44862> why is both rollback and commit done? - Koushik Das On June 11, 2013, 6:38 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11435/ > ----------------------------------------------------------- > > (Updated June 11, 2013, 6:38 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Koushik Das. > > > Description > ------- > > [Multiple_IP_Ranges] Failed to delete guest IP range from a new subnet/C > https://issues.apache.org/jira/browse/CLOUDSTACK-2621 > > > This addresses bug Cloudstack-2621. > > > Diffs > ----- > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > c71d037 > > Diff: https://reviews.apache.org/r/11435/diff/ > > > Testing > ------- > > tested on master. > > > Thanks, > > bharat kumar > >
