----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11989/#review22161 -----------------------------------------------------------
Ship it! Ship It! - Nitin Mehta On June 20, 2013, 9:42 a.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11989/ > ----------------------------------------------------------- > > (Updated June 20, 2013, 9:42 a.m.) > > > Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. > > > Description > ------- > > CLOUDSTACK-2916: admin is not able to login through UI after setting GP > "cluster.cpu.allocated.capacity.notificationthreshold" to some string > CLOUDSTACK-2457: No check for input values,special character,-ive values can > be assigne to GLobal parameter > "cluster.cpu.allocated.capacity.disablethreshold" > > Added validation for float values and checking limit for weight based > parameters by creating a set of parameters. > > > This addresses bugs CLOUDSTACK-2457 and CLOUDSTACK-2916. > > > Diffs > ----- > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 131d340 > > Diff: https://reviews.apache.org/r/11989/diff/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Harikrishna Patnala > >
