> On July 3, 2013, 3:58 p.m., bharat kumar wrote:
> > server/src/com/cloud/configuration/ConfigurationManagerImpl.java, line 3054
> > <https://reviews.apache.org/r/12251/diff/1/?file=318002#file318002line3054>
> >
> > removed the sql exception
Bharat, I still see SQLException being caught:
} catch (SQLException e) {
3090
throw new CloudRuntimeException(e.getMessage());
3104
}
3091
}
Can you please remove this try/catch as you are not throwing the exception any
longer?
- Alena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12251/#review22722
-----------------------------------------------------------
On July 3, 2013, 3:50 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12251/
> -----------------------------------------------------------
>
> (Updated July 3, 2013, 3:50 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk, Abhinandan Prateek, and
> Sheng Yang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Incorporating the review comments given by Alena and Sheng.
>
>
> Diffs
> -----
>
> api/src/com/cloud/agent/api/to/DnsmasqTO.java c7be04d
> api/src/com/cloud/network/element/DhcpServiceProvider.java 83008ca
> core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java a52af90
> core/src/com/cloud/network/DnsMasqConfigurator.java dd34926
> engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3eba6d8
> engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 1051b69
> patches/systemvm/debian/config/root/createIpAlias.sh 1db210b
> patches/systemvm/debian/config/root/deleteIpAlias.sh cf6d4de
> patches/systemvm/debian/config/root/dnsmasq.sh 656fd3c
> scripts/network/domr/call_dnsmasq.sh 097e185
> scripts/vm/hypervisor/xenserver/createipAlias.sh c35658e
> scripts/vm/hypervisor/xenserver/deleteipAlias.sh 6816edd
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 27c1a51
> server/src/com/cloud/network/NetworkServiceImpl.java 8cdcfde
> server/src/com/cloud/network/element/VirtualRouterElement.java 1916678
> server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
> e863af4
> utils/src/com/cloud/utils/net/NetUtils.java 5c13454
>
> Diff: https://reviews.apache.org/r/12251/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> bharat kumar
>
>
