----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12251/#review22900 -----------------------------------------------------------
server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/12251/#comment46649> You can remove the catch as you jurt rethrow the caught exception. - Abhinandan Prateek On July 8, 2013, 5:47 p.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12251/ > ----------------------------------------------------------- > > (Updated July 8, 2013, 5:47 p.m.) > > > Review request for cloudstack, Alena Prokharchyk, Abhinandan Prateek, and > Sheng Yang. > > > Repository: cloudstack-git > > > Description > ------- > > Incorporating the review comments given by Alena and Sheng. > > > Diffs > ----- > > engine/schema/src/com/cloud/network/dao/IPAddressDao.java 3eba6d8 > engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java 1051b69 > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 27c1a51 > > Diff: https://reviews.apache.org/r/12251/diff/ > > > Testing > ------- > > > Thanks, > > bharat kumar > >