-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12271/#review22769
-----------------------------------------------------------


Commit 048cf5aae84786d2d3515a3199271e87c0c7bafb in branch refs/heads/master 
from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=048cf5a ]

CLOUDSTACK-2884: Fixed test_04_change_offering_small

Added method to compare if two digits are almost equal within given range

Signed-off-by: Prasanna Santhanam <t...@apache.org>


- ASF Subversion and Git Services


On July 4, 2013, 10:33 a.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12271/
> -----------------------------------------------------------
> 
> (Updated July 4, 2013, 10:33 a.m.)
> 
> 
> Review request for cloudstack and Prasanna Santhanam.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Resolved Issue 2884: Test case 
> "test_service_offerings.py:test_04_change_offering_small for VMWare and KVM.
> Earlier there was str to int type conversion issue for assertAlmostEqual 
> function. Now instead of that, I have added own function to check if the two 
> digits are almost equal within particular range.
> 
> During execution of test case, it was observed that there is difference of 10 
> in total_memory and offering memory. I have set range as 20.
> 
> The test case runs fine on KVM and VMware.
> 
> 
> Diffs
> -----
> 
>   test/integration/smoke/test_service_offerings.py 0213c04 
> 
> Diff: https://reviews.apache.org/r/12271/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>

Reply via email to