----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12271/#review22771 -----------------------------------------------------------
Ship it! - Prasanna Santhanam On July 4, 2013, 10:33 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12271/ > ----------------------------------------------------------- > > (Updated July 4, 2013, 10:33 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > Resolved Issue 2884: Test case > "test_service_offerings.py:test_04_change_offering_small for VMWare and KVM. > Earlier there was str to int type conversion issue for assertAlmostEqual > function. Now instead of that, I have added own function to check if the two > digits are almost equal within particular range. > > During execution of test case, it was observed that there is difference of 10 > in total_memory and offering memory. I have set range as 20. > > The test case runs fine on KVM and VMware. > > > Diffs > ----- > > test/integration/smoke/test_service_offerings.py 0213c04 > > Diff: https://reviews.apache.org/r/12271/diff/ > > > Testing > ------- > > > Thanks, > > Gaurav Aradhye > >
