Pearl1594 commented on code in PR #69:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/69#discussion_r1686689894
##########
cloudstack_loadbalancer.go:
##########
@@ -790,6 +852,29 @@ func (lb *loadBalancer) updateFirewallRule(publicIpId
string, publicPort int, pr
return true, err
}
+func (lb *loadBalancer) updateNetworkACL(publicPort int, protocol
LoadBalancerProtocol, networkId string) (bool, error) {
+ network, _, err := lb.Network.GetNetworkByID(networkId)
+ if err != nil {
+ return false, fmt.Errorf("error fetching Network with ID: %v,
due to: %s", networkId, err)
+ }
+
+ // create ACL rule
+ acl := lb.NetworkACL.NewCreateNetworkACLParams(protocol.CSProtocol())
+ acl.SetAclid(network.Aclid)
+ acl.SetAction("Allow")
Review Comment:
ideally should not be required. Because, these rules correspond to the LB
service created on Kubernetes side. So these would ideally be fixed to action:
"allow" and traffictype: "Ingress"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
