weizhouapache commented on code in PR #69:
URL:
https://github.com/apache/cloudstack-kubernetes-provider/pull/69#discussion_r1686729279
##########
cloudstack_loadbalancer.go:
##########
@@ -828,6 +913,42 @@ func (lb *loadBalancer) deleteFirewallRule(publicIpId
string, publicPort int, pr
return deleted, err
}
+// Delete Network ACLs deletes the Network ACL rule associated with the
ip:port:protocol combo
+func (lb *loadBalancer) deleteNetworkACLRule(publicPort int, protocol
LoadBalancerProtocol, networkID string) (bool, error) {
+ p := lb.NetworkACL.NewListNetworkACLsParams()
+ p.SetListall(true)
+ p.SetNetworkid(networkID)
+ if lb.projectID != "" {
+ p.SetProjectid(lb.projectID)
+ }
+
+ r, err := lb.NetworkACL.ListNetworkACLs(p)
+ if err != nil {
+ return false, fmt.Errorf("error fetching Network ACL rules
Network ID %v: %v", networkID, err)
+ }
+
+ // filter by proto:port
+ filtered := make([]*cloudstack.NetworkACL, 0, 1)
+ for _, rule := range r.NetworkACLs {
+ if rule.Protocol == protocol.IPProtocol() && rule.Startport ==
strconv.Itoa(publicPort) && rule.Endport == strconv.Itoa(publicPort) {
+ filtered = append(filtered, rule)
+ }
+ }
+
+ // delete all rules
+ deleted := false
+ ruleToBeDeleted := filtered[0]
Review Comment:
is it possible that this throws a out-of-bound exception, if `filtered` is
empty ?
##########
cloudstack_loadbalancer.go:
##########
@@ -828,6 +913,42 @@ func (lb *loadBalancer) deleteFirewallRule(publicIpId
string, publicPort int, pr
return deleted, err
}
+// Delete Network ACLs deletes the Network ACL rule associated with the
ip:port:protocol combo
+func (lb *loadBalancer) deleteNetworkACLRule(publicPort int, protocol
LoadBalancerProtocol, networkID string) (bool, error) {
+ p := lb.NetworkACL.NewListNetworkACLsParams()
+ p.SetListall(true)
+ p.SetNetworkid(networkID)
+ if lb.projectID != "" {
+ p.SetProjectid(lb.projectID)
+ }
+
+ r, err := lb.NetworkACL.ListNetworkACLs(p)
+ if err != nil {
+ return false, fmt.Errorf("error fetching Network ACL rules
Network ID %v: %v", networkID, err)
+ }
+
+ // filter by proto:port
+ filtered := make([]*cloudstack.NetworkACL, 0, 1)
+ for _, rule := range r.NetworkACLs {
+ if rule.Protocol == protocol.IPProtocol() && rule.Startport ==
strconv.Itoa(publicPort) && rule.Endport == strconv.Itoa(publicPort) {
+ filtered = append(filtered, rule)
+ }
+ }
+
+ // delete all rules
Review Comment:
delete the first filtered rule ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
