----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12972/ -----------------------------------------------------------
(Updated July 28, 2013, 4:39 a.m.) Review request for cloudstack, Prasanna Santhanam and Sheng Yang. Changes ------- Thanks so much for testing. Here's a new diff, this one should be ready to apply as an all-in-one that addresses some of your comments and cleans up the old vm_data stuff. Changes: * Moved vmdata_kvm.py to vmdata.py, changed script name in VirtualRoutingResource and CitrixResourceBase accordingly * Cleaned up vm_data from the vmops python scripts (I hope I did this correctly) * Removed vm_data.sh again * Removed references to vm_data.sh in xenserver patch scripts (I assume these copy the scripts to xenserver hosts) I left the print statements alone for now, I'm not sure of the availability of utils.SMLog within the virtual router or compatibility with KVM. Bugs: CLOUDSTACK-3163 Repository: cloudstack-git Description ------- Update CitrixResourceBase to use new vmdata programming method, removing dozens of ssh/scp calls on router and vm startup. This will get rid of vm_data.sh. Diffs (updated) ----- core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java e5f922d patches/systemvm/debian/config/opt/cloud/bin/vmdata.py PRE-CREATION patches/systemvm/debian/config/opt/cloud/bin/vmdata_kvm.py f508032 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 7f8bb3e scripts/network/domr/vm_data.sh c861723 scripts/vm/hypervisor/xenserver/vmops 9a0ef44 scripts/vm/hypervisor/xenserver/xcposs/patch 4d07c76 scripts/vm/hypervisor/xenserver/xcposs/vmops 52625e1 scripts/vm/hypervisor/xenserver/xcpserver/patch 7e92d5a scripts/vm/hypervisor/xenserver/xenserver56/patch 8abd6b2 scripts/vm/hypervisor/xenserver/xenserver56fp1/patch 901f6de scripts/vm/hypervisor/xenserver/xenserver60/patch d7da374 Diff: https://reviews.apache.org/r/12972/diff/ Testing ------- None, please test. Thanks, Marcus Sorensen
