> On July 31, 2013, 3:22 a.m., Sheng Yang wrote: > > Ship It!
Looks fine to me. - Sheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12972/#review24316 ----------------------------------------------------------- On July 31, 2013, 2:52 a.m., Marcus Sorensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12972/ > ----------------------------------------------------------- > > (Updated July 31, 2013, 2:52 a.m.) > > > Review request for cloudstack, Prasanna Santhanam and Sheng Yang. > > > Bugs: CLOUDSTACK-3163 > > > Repository: cloudstack-git > > > Description > ------- > > Update CitrixResourceBase to use new vmdata programming method, removing > dozens of ssh/scp calls on router and vm startup. This will get rid of > vm_data.sh. > > > Diffs > ----- > > > core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java > e5f922d > patches/systemvm/debian/config/opt/cloud/bin/vmdata.py PRE-CREATION > patches/systemvm/debian/config/opt/cloud/bin/vmdata_kvm.py f508032 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > fa7f2ec > scripts/network/domr/vm_data.sh c861723 > scripts/vm/hypervisor/xenserver/vmops ff33c2d > scripts/vm/hypervisor/xenserver/xcposs/patch 4d07c76 > scripts/vm/hypervisor/xenserver/xcposs/vmops 52625e1 > scripts/vm/hypervisor/xenserver/xcpserver/patch 7e92d5a > scripts/vm/hypervisor/xenserver/xenserver56/patch 8abd6b2 > scripts/vm/hypervisor/xenserver/xenserver56fp1/patch 901f6de > scripts/vm/hypervisor/xenserver/xenserver60/patch d7da374 > > Diff: https://reviews.apache.org/r/12972/diff/ > > > Testing > ------- > > None, please test. > > > Thanks, > > Marcus Sorensen > >
