----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13008/ -----------------------------------------------------------
(Updated July 30, 2013, 3:46 a.m.) Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang, Sateesh Chodapuneedi, and William Chan. Changes ------- Updating the review request with a patch that now uses a custom field by name CLOUD_INTERNAL_VM_NAME instead of the annotation field. All testing as before has been carried out with these new changes and confirmed to work as expected. Please note that this patch is for 4.2 only and will not apply on master and hence a failure message will show up on this request. Requesting that the committer use git am to apply the patch to ensure that patch application goes through smoothly. Regards, Vijay Bugs: CLOUDSTACK-3886 Repository: cloudstack-git Description ------- The vminstancename flag has been incorrectly used to simply append the displayname to the internal VM name that shows up on vCenter in vmware deployments. It was intended to show the actual name supplied as hostname, on the hypervisor. This helps admins and deployers to quickly identify VMs and resolve issues related to those VMs. Its usage is very limited as it stands now. This fix corrects it to ensure that the name of the VM on the hypervisor matches the hostname if it is supplied, and if the vm.instancename.flag is set to true. Diffs (updated) ----- engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java 96fb1d9 plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java d1392c4 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 8d6bdb8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java 3dece6e plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java a33b94e plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java 6451828 server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04 server/src/com/cloud/hypervisor/HypervisorGuruBase.java 478baf3 server/src/com/cloud/vm/UserVmManagerImpl.java 280f7e9 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 45aa50c vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8 vmware-base/src/com/cloud/hypervisor/vmware/mo/CustomFieldConstants.java 11bc157 vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0 vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java dd0f889 vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java e2dd789 vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java ac14328 Diff: https://reviews.apache.org/r/13008/diff/ Testing ------- Post this change, all major VM operations, namely creation/destruction/expunging/start/stop/reboot of the VM have been tested and observed to work correctly. Part of this patch also puts in a fix for VMSync operations where the CS mgmt server doesn't detect that a guest VM is down, if the guest VM has been shut down/powered off in vCenter. Other operations such as VM snapshot, volume snapshots of disks belonging to the VM, volume migration across primaries, volume attach/detach have also been tested and they are working as expected. This is a functional change, and completely transparent to any of cloudstack's existing functionalities and all the test cases that cover the above code paths and APIs - all existing tests should and do pass - no new tests are necessary. Thanks, Venkata Siva Vijayendra Bhamidipati
