-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13008/#review24812
-----------------------------------------------------------
Ship it!
commit 059e4b2ae0a44205a8567a79bf9a154a54a83492
Author: Kelven Yang <kelv...@gmail.com>
Date: Wed Aug 7 10:28:47 2013 -0700
CLOUDSTACK-3886: check in for review request
https://reviews.apache.org/r/13008/
- Kelven Yang
On Aug. 6, 2013, 9:10 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13008/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2013, 9:10 p.m.)
>
>
> Review request for cloudstack, Alex Huang, Chip Childers, Kelven Yang,
> Sateesh Chodapuneedi, and William Chan.
>
>
> Bugs: CLOUDSTACK-3886
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> The vminstancename flag has been incorrectly used to simply append the
> displayname to the internal VM name that shows up on vCenter in vmware
> deployments. It was intended to show the actual name supplied as hostname, on
> the hypervisor. This helps admins and deployers to quickly identify VMs and
> resolve issues related to those VMs. Its usage is very limited as it stands
> now. This fix corrects it to ensure that the name of the VM on the hypervisor
> matches the hostname if it is supplied, and if the vm.instancename.flag is
> set to true.
>
>
> Diffs
> -----
>
>
> engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java
> 96fb1d9
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java
> 292f7e9
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java
> 8d6bdb8
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
> 6b721de
>
> plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
> d395425
>
> plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
> fe127e3
> server/src/com/cloud/configuration/Config.java ad8e3aa
> server/src/com/cloud/ha/HighAvailabilityManagerImpl.java 25c5a04
> server/src/com/cloud/hypervisor/HypervisorGuruBase.java e042eb8
> server/src/com/cloud/vm/UserVmManagerImpl.java 4a222c4
> server/src/com/cloud/vm/VirtualMachineManagerImpl.java b33ee49
> setup/db/db/schema-410to420.sql b3206af
> vmware-base/src/com/cloud/hypervisor/vmware/mo/ClusterMO.java 04ef0f8
> vmware-base/src/com/cloud/hypervisor/vmware/mo/CustomFieldConstants.java
> 11bc157
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HostMO.java 2735fb0
> vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
> d20eb6f
> vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
> cb97b26
> vmware-base/src/com/cloud/hypervisor/vmware/mo/VmwareHypervisorHost.java
> ac14328
>
> Diff: https://reviews.apache.org/r/13008/diff/
>
>
> Testing
> -------
>
> Post this change, all major VM operations, namely
> creation/destruction/expunging/start/stop/reboot of the VM have been tested
> and observed to work correctly. Part of this patch also puts in a fix for
> VMSync operations where the CS mgmt server doesn't detect that a guest VM is
> down, if the guest VM has been shut down/powered off in vCenter. Other
> operations such as VM snapshot, volume snapshots of disks belonging to the
> VM, volume migration across primaries, volume attach/detach have also been
> tested and they are working as expected. This is a functional change, and
> completely transparent to any of cloudstack's existing functionalities and
> all the test cases that cover the above code paths and APIs - all existing
> tests should and do pass - no new tests are necessary.
>
>
> UPDATE for 08/05/2013
> =====================
> 4.2 code has diverged - need to refactor the patch on top of latest 4.2. Will
> test out refactored patch and resubmit.
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>
