----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13001/#review24321 -----------------------------------------------------------
test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48151> Here, test is verifying resource count not the resource limit test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48148> To get the resource count for an account, instead of using updateResourceCount API, use listAccounts API. test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48150> use listAccounts API. Also, the resource count for CPU should be same as the previous count. Use Assert to verify that. test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48152> use listAccounts API. test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48153> This test should be of assigning VM to other account and not of Migrating VM, because assigning VM to other account changes the resource count for both the accounts, on the other hand, migrate VM to other host will not affect any count because VM still belongs to the same account. test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48154> resource count not limit. test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48155> use listAccounts API. test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48156> make it "List Resource count" test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48157> verify resource count not limit. test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48158> use listAccounts API. test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48159> use listAccounts API to get the count and verify the count using assert. test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48160> again use assert to verify the count. test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48162> use different name for this domain object as "domain" object already exists. test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48172> please update the description as per the test as you are not setting any limit in this test. test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48167> use listAccounts API, also use assert to verify the expected count. test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48170> instead of doing stopping and starting of the instance, use reboot command to reboot the instance. test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48175> use assert to verify the expected count and not the debug statement. test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48178> remove this line if the test is not using this configuration. test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48180> use listResourceLimit API to get the limit value. test/integration/component/cpu_limits/test_cpu_limits.py <https://reviews.apache.org/r/13001/#comment48190> use listAccounts and assert to verify. - Sanjay Tripathi On July 30, 2013, 10:27 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13001/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 10:27 a.m.) > > > Review request for cloudstack, Girish Shilamkar, sailaja mada, Sanjay > Tripathi, and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > Adding test cases for CPU limits from Limit Resources. > Marvin changes have to be picked up from Memory Limits patch > (https://reviews.apache.org/r/11626/). Those are not included in this patch. > > > Diffs > ----- > > test/integration/component/cpu_limits/test_cpu_limits.py PRE-CREATION > test/integration/component/cpu_limits/test_domain_limits.py PRE-CREATION > test/integration/component/cpu_limits/test_maximum_limits.py PRE-CREATION > test/integration/component/cpu_limits/test_project_limits.py PRE-CREATION > > Diff: https://reviews.apache.org/r/13001/diff/ > > > Testing > ------- > > > Thanks, > > Gaurav Aradhye > >
