> On July 31, 2013, 6:08 a.m., Sanjay Tripathi wrote: > > test/integration/component/cpu_limits/test_cpu_limits.py, line 216 > > <https://reviews.apache.org/r/13001/diff/2/?file=330095#file330095line216> > > > > This test should be of assigning VM to other account and not of > > Migrating VM, because assigning VM to other account changes the resource > > count for both the accounts, on the other hand, migrate VM to other host > > will not affect any count because VM still belongs to the same account.
Hi Sanjay, This test verifies the same according to test scenario that the resource count should not change after migrating. Will add new test case for assigning VM on top of this. - Gaurav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13001/#review24321 ----------------------------------------------------------- On Aug. 8, 2013, 12:51 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13001/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2013, 12:51 p.m.) > > > Review request for cloudstack, Girish Shilamkar, sailaja mada, Sanjay > Tripathi, and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > Adding test cases for CPU limits from Limit Resources. > Marvin changes have to be picked up from Memory Limits patch > (https://reviews.apache.org/r/11626/). Those are not included in this patch. > > > Diffs > ----- > > test/integration/component/cpu_limits/test_cpu_limits.py PRE-CREATION > test/integration/component/cpu_limits/test_domain_limits.py PRE-CREATION > test/integration/component/cpu_limits/test_maximum_limits.py PRE-CREATION > test/integration/component/cpu_limits/test_project_limits.py PRE-CREATION > tools/marvin/marvin/integration/lib/base.py b5d086b > tools/marvin/marvin/integration/lib/common.py 4f5acef > > Diff: https://reviews.apache.org/r/13001/diff/ > > > Testing > ------- > > > Thanks, > > Gaurav Aradhye > >
