LGTM On 8/20/13 6:54 AM, "Chip Childers" <chip.child...@sungard.com> wrote:
>On Mon, Aug 19, 2013 at 10:19:28PM +0000, Chiradeep Vittal wrote: >> I think developers will anyway try to optimize their build time. >> This cannot be helped. >> The danger of course is that they 'git push' before running the full >>build. > >Agreed, but I'd at least like to ensure that the full build includes >that check. It's an incremental improvement IMO. Anyone object? > >> >> On 8/19/13 11:39 AM, "Chip Childers" <chip.child...@sungard.com> wrote: >> >> >Hey all, >> > >> >Apache RAT 0.10 has been released, improving the speed for a RAT check >> >quite a bit. I've gone ahead and changed the builds.a.o jobs to use >> >version 0.10. >> > >> >I'd like to propose that we add the plugin to our default build, now >> >that it's faster. You can see the speed by running: >> > >> >mvn --projects='org.apache.cloudstack:cloudstack' >> >org.apache.rat:apache-rat-plugin:0.10:check >> > >> >And can compare with 0.8 using: >> > >> >mvn --projects='org.apache.cloudstack:cloudstack' >> >org.apache.rat:apache-rat-plugin:0.8:check >> > >> > >> >This would help us ensure that we don't have licensing issues lingering >> >out on CI servers with little attention. >> > >> >-chip >> >>
