----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13807/ -----------------------------------------------------------
Review request for cloudstack and Nitin Mehta. Bugs: Cloudstack-4498 Repository: cloudstack-git Description ------- https://issues.apache.org/jira/browse/CLOUDSTACK-4498 we should not reserve memory and cpu for vmware VMs if the vmware.reserve.cpu and vmware.reserve.mem are set to false. currently overcommit dose not honor the flag vmware.reserve.mem and vmware.reserve.cpu. Now we have fixed this and brought down these parameters to cluster level. Diffs ----- plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java 8aae8c8 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 4d24562 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 9cb6115 server/src/com/cloud/configuration/Config.java 8955087 vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java e545c8e Diff: https://reviews.apache.org/r/13807/diff/ Testing ------- Tested on 4.2 Thanks, bharat kumar
