----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13807/#review25610 -----------------------------------------------------------
server/src/com/cloud/configuration/Config.java <https://reviews.apache.org/r/13807/#comment50078> Please add that "In case of cpu overprovisioning we will always reserve cpu" - Nitin Mehta On Aug. 27, 2013, 10:47 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13807/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2013, 10:47 a.m.) > > > Review request for cloudstack and Nitin Mehta. > > > Bugs: Cloudstack-4498 > > > Repository: cloudstack-git > > > Description > ------- > > https://issues.apache.org/jira/browse/CLOUDSTACK-4498 > we should not reserve memory and cpu for vmware VMs if the vmware.reserve.cpu > and vmware.reserve.mem are set to false. > > currently overcommit dose not honor the flag vmware.reserve.mem and > vmware.reserve.cpu. Now we have fixed this and brought down these parameters > to cluster level. > > > Diffs > ----- > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java > 8aae8c8 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java > 4d24562 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 87e2e93 > server/src/com/cloud/configuration/Config.java 1cc31b6 > > Diff: https://reviews.apache.org/r/13807/diff/ > > > Testing > ------- > > Tested on 4.2 > > > Thanks, > > bharat kumar > >
