> On Aug. 27, 2013, 2:48 p.m., Sanjay Tripathi wrote: > > Looks good to me.
Thanks for the detailed review Sanjay. I've merged this to master/4.2-forward. Gaurav, there were many formatting errors in the patch. Please verify the merge and ensure that you've checked for formatting in your future patches. Thanks - Prasanna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13001/#review25619 ----------------------------------------------------------- On Aug. 27, 2013, 1:32 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13001/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2013, 1:32 p.m.) > > > Review request for cloudstack, Girish Shilamkar, sailaja mada, Sanjay > Tripathi, and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > Adding test cases for CPU limits from Limit Resources. > Marvin changes have to be picked up from Memory Limits patch > (https://reviews.apache.org/r/11626/). Those are not included in this patch. > > > Diffs > ----- > > test/integration/component/cpu_limits/test_cpu_limits.py PRE-CREATION > test/integration/component/cpu_limits/test_domain_limits.py PRE-CREATION > test/integration/component/cpu_limits/test_maximum_limits.py PRE-CREATION > test/integration/component/cpu_limits/test_project_limits.py PRE-CREATION > tools/marvin/marvin/integration/lib/base.py 91cfebd > tools/marvin/marvin/integration/lib/common.py 4f5acef > > Diff: https://reviews.apache.org/r/13001/diff/ > > > Testing > ------- > > > Thanks, > > Gaurav Aradhye > >