> This API is called by UI to implement toggle effect for icon "Add/Remove > VMware Datacenter".
[Jesisca] No, listVmwareDcs API was called by UI to get VMware DataCenter info to display in zone detail page (which has 3 fields: "VMware dataCenter Name", "VMware dataCenter vcenter", "VMware dataCenter Id"), NOT to toggle effect for icon "Add/Remove VMware Datacenter". > [Chip] Shouldn't we consider making the UI respond appropriately to a missing > API > (i.e.: don't show that feature if the API response to that call is an error > saying that the API call doesn't exist)? [Jessica] There is no way for UI to know whether an API command is missing or not before calling it. After calling an API command, if API returns error "Unknown API command", UI will suppress the error message (i.e. UI will not pop up a dialog showing "Unknown API command"). The error "Unknown API command" was seen in the log, NOT on UI. However, I just checked in an UI enhancement to skip calling listVmwareDcs API if a zone doesn't have any VMware cluster(s). -----Original Message----- From: Chip Childers [mailto:chip.child...@sungard.com] Sent: Friday, September 06, 2013 9:08 AM To: dev@cloudstack.apache.org Cc: Animesh Chaturvedi Subject: Re: Questions about 4.2 RC On Fri, Sep 06, 2013 at 03:21:24PM +0000, Sateesh Chodapuneedi wrote: > > -----Original Message----- > > From: Edison Su [mailto:edison...@citrix.com] > > Sent: 06 September 2013 02:08 > > To: dev@cloudstack.apache.org; Animesh Chaturvedi > > Subject: RE: Questions about 4.2 RC > > > > > > > > > -----Original Message----- > > > From: sebgoa [mailto:run...@gmail.com] > > > Sent: Thursday, September 05, 2013 1:22 AM > > > To: dev@cloudstack.apache.org; Animesh Chaturvedi > > > Subject: Questions about 4.2 RC > > > > > > Hi, > > > > > > I followed the testing procedure for the 4.2 RC, I am ready to vote +1 > > > but I have questions (hence the new thread, don't want to hijack the > > > VOTE). > > > > > > 1. the CHANGES file points to the release notes, but where are the > > > release notes ? I know that no-one really stepped up on the RN but > > > can't we at a minimum do a JIRA query that lists the bugs fixed in 4.2 > > > and the new features ? > > > > > > 2. Under infrastructure when I view the DevCloud Zone, I get this in the > > > log: > > > WARN [cloud.api.ApiServer] (642225853@qtp-111037821-10:) Unknown API > > > command: listVmwareDcs This is not a deal breaker but why is our UI > > > calling a non-implemented API ? This sounds like introducing known > > > issues. If it's not implemented yet, remove it. > > > > The command is only available in non-oss build, but is still listed in > > command.properties, as there is no separate file for commands non-oss > > build. > Yes, this command is only available in non-oss build and had to be placed in > command.properties as no separate file available for non-oss build. > This API is called by UI to implement toggle effect for icon "Add/Remove > VMware Datacenter". This icon is associated with a cloudstack zone. > If we drop the toggle functionality from UI then we need to have 2 icons > instead (one for "Add" and other for "Remove"). Shouldn't we consider making the UI respond appropriately to a missing API (i.e.: don't show that feature if the API response to that call is an error saying that the API call doesn't exist)?
