Mike, everyone,
As I've mentioned on the board, I'm working on getting our own
internal KVM storage plugin working on 4.2. In the interest of making
it forward compatible, I just wanted to confirm what you were doing
with the solidfire plugin as far as attaching your iscsi LUNs. We had
discussed a new connectPhysicalDisk method for the StorageAdaptor
class, something perhaps like:
public boolean connectPhysicalDisk(String volumeUuid, KVMStoragePool pool);
then added to KVMStoragePoolManager:
public boolean connectPhysicalDisk(StoragePoolType type, String
poolUuid, String volPath) {
StorageAdaptor adaptor = getStorageAdaptor(type);
KVMStoragePool pool = adaptor.getStoragePool(poolUuid);
return adaptor.connectPhysicalDisk(volPath, pool);
}
Something similar to this for disconnect as well. Then in the
KVMStorageProcessor these can be called as needed for attach/detach.
We can probably stub out one in LibvirtStorageAdaptor so there's no
need to switch or if/else for pool types, for example in
KVMStorageProcessor.attachVolume.
I have debated on whether or not it should just be rolled into
getPhysicalDisk, having it connect the disk if it's not already
connected. getPhysicalDisk is called a lot, and I'm not sure it always
needs to connect the disk when it does. In past iterations
getPhysicalDisk has simply spoken to our SAN api and returned the disk
details, nothing more. So it seemed more flexible and granular to do
the connectPhysicalDisk (we have one now in our 4.1 version).
