I discarded the patch. The purpose of throwing it up on review board was so that people could comment on the impact. And the impact is bad.
Darren > On Sep 28, 2013, at 4:43 AM, "daan Hoogland" <daan.hoogl...@gmail.com> wrote: > > > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14360/ > > On September 27th, 2013, 8:21 p.m. UTC, Alena Prokharchyk wrote: > > Darren, changes in Network.java are going to break API compatibility as > capabilities parameters are used in createNetworkOffering API call > (serviceCapabilitystList param). CS UI and third party UI will get impacted > as well. > If we have to change the name, its gotta be the capability parameter name, > not its name value. > This in turn, could have impact on other uses, like in a db could it? > > @Darren: you will need a lot more then just a (unit)test for the getname() > > - daan > > > On September 27th, 2013, 5:43 p.m. UTC, Darren Shepherd wrote: > > Review request for cloudstack, Alena Prokharchyk and Chiradeep Vittal. > By Darren Shepherd. > Updated Sept. 27, 2013, 5:43 p.m. > > Repository: cloudstack-git > Description > > VPCVirtualRouter is still left as inconsitent as changing that name will be > impactful. The unit test checked in will still ensure that future providers > match though > Diffs > > api/src/com/cloud/network/Network.java (49f380b) > api/test/com/cloud/network/NetworkTest.java (PRE-CREATION) > View Diff
