> On Sept. 27, 2013, 8:21 p.m., Alena Prokharchyk wrote: > > Darren, changes in Network.java are going to break API compatibility as > > capabilities parameters are used in createNetworkOffering API call > > (serviceCapabilitystList param). CS UI and third party UI will get impacted > > as well. > > If we have to change the name, its gotta be the capability parameter name, > > not its name value. > > daan Hoogland wrote: > This in turn, could have impact on other uses, like in a db could it? > > @Darren: you will need a lot more then just a (unit)test for the getname()
Won't impact the DB as there is no direct ref between capability name and DB field name /value. - Alena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14360/#review26447 ----------------------------------------------------------- On Sept. 27, 2013, 5:43 p.m., Darren Shepherd wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14360/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2013, 5:43 p.m.) > > > Review request for cloudstack, Alena Prokharchyk and Chiradeep Vittal. > > > Repository: cloudstack-git > > > Description > ------- > > VPCVirtualRouter is still left as inconsitent as changing that name will be > impactful. The unit test checked in will still ensure that future providers > match though > > > Diffs > ----- > > api/src/com/cloud/network/Network.java 49f380b > api/test/com/cloud/network/NetworkTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/14360/diff/ > > > Testing > ------- > > > Thanks, > > Darren Shepherd > >
