> On Oct. 16, 2013, 4:43 p.m., Santhosh Edukulla wrote: > > Sowmya, > > > > > > Is it ok if we do a code walkthrough? Let me know i can create a gtm. > > Also,please add the path to test plan for this feature along with feature > > owner information, i will invite him\her as well. > > > > santhosh > > Sowmya Krishnan wrote: > Sure. Test plan is here: https://cwiki.apache.org/confluence/x/xIzlAQ > I had done the testing for the feature and dev was done by Rajesh(already > added as reviewer for this patch) > > Prasanna Santhanam wrote: > Any meeting notes or corrections from this review meeting? > > Santhosh Edukulla wrote: > There were few review comments. We are doing the review again tomorrow.
Did few more changes to the patch: 1. Edited Comments/Description for many tests. It was just wrong/copy-paste of first test. 2. Removed commented code Following based on review comments: 1. Replaced global for Netscaler configuration in setUpClass() with class attribute: ns_configured. Another option to this was to add an attribute to services class. But that wouldn't work with the current design of tests since we re-initialize services() class attributes in setUp() which runs before every test. So the value assigned in setUpClass will be lost. Hence followed this approach. 2. Removed non-functioning if statements 3. Removed VPC creation from test_10_create_network_with_conserve_mode 4. Few naming convention changes Apart from these, few generic discussions came up, mostly around handling exceptions for API calls which we presently don't religiously follow across all tests. Filed couple of tickets to track those issues (something to be fixed across all tests): CLOUDSTACK-4972, CLOUDSTACK-4974 - Sowmya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14426/#review27068 ----------------------------------------------------------- On Oct. 28, 2013, 5:53 a.m., Sowmya Krishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14426/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2013, 5:53 a.m.) > > > Review request for cloudstack, Rajesh Battala, Santhosh Edukulla, and Sowmya > Krishnan. > > > Bugs: CLOUDSTACK-4776 > https://issues.apache.org/jira/browse/CLOUDSTACK-4776 > > > Repository: cloudstack-git > > > Description > ------- > > Created tests for Netscaler as external LB provider in VPC > Used ddt to achieve this without adding new tests but modifying the existing > tests > Created new network_offering_vpcNS > Handled addition on NS as optional in setup - if NS addition fails, the > non-NS tests still work and NS tests alone will be skipped > Removed the creation of vpc Offering for each test, instead, using Default > offering > test_03_create_network_netscaler is no more valid - removed it. I am adding > new tests for NS as external LB provider. So this is not needed. > > > Diffs > ----- > > test/integration/component/test_vpc_network.py 970a625 > > Diff: https://reviews.apache.org/r/14426/diff/ > > > Testing > ------- > > Tested script locally. Long running script... Latest run looks good so far. > > output so far: > Test create network in VPC ... ok > Test create network in VPC ... ok > Test create network in VPC mismatched services (Should fail) ... ok > Test create network in VPC mismatched services (Should fail) ... ok > Test create multiple networks with LB service (Should fail) ... ok > Test create multiple networks with LB service (Should fail) ... ok > Test create network with external LB devices ... ok > Test create network with redundant router capability ... SKIP: skipped - RvR > didn't support VPC currently > Test create network services not supported by VPC (Should fail) ... ok > Test create network without sourceNAT service in VPC (should fail) ... ok > Test create network with shared network offering ... ok > Test create network with shared network offering ... ok > Test create network with conserve mode ON ... ok > Test create network with conserve mode ON ... ok > Test network gc after shutdown of vms in the network ... FAIL > Test network rules after starting a VpcVr that was shutdown after network.gc > ... ok > Test Stop all the Vms that are part of the a Network ... ok > Test create network outside cidr range of VPC ... ok > Test create network outside cidr range of VPC ... ok > Test create network outside cidr range of VPC ... ok > Test create network inside cidr range of VPC ... ok > Test create network inside cidr range of VPC ... ok > Test create network overlapping cidr range of VPC ... > > > Thanks, > > Sowmya Krishnan > >
