----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14426/#review27877 -----------------------------------------------------------
Ship it! Ship It! - Santhosh Edukulla On Oct. 28, 2013, 7:03 a.m., Sowmya Krishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14426/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2013, 7:03 a.m.) > > > Review request for cloudstack, Rajesh Battala, Santhosh Edukulla, and Sowmya > Krishnan. > > > Bugs: CLOUDSTACK-4776 > https://issues.apache.org/jira/browse/CLOUDSTACK-4776 > > > Repository: cloudstack-git > > > Description > ------- > > Created tests for Netscaler as external LB provider in VPC > Used ddt to achieve this without adding new tests but modifying the existing > tests > Created new network_offering_vpcNS > Handled addition on NS as optional in setup - if NS addition fails, the > non-NS tests still work and NS tests alone will be skipped > Removed the creation of vpc Offering for each test, instead, using Default > offering > test_03_create_network_netscaler is no more valid - removed it. I am adding > new tests for NS as external LB provider. So this is not needed. > > > Diffs > ----- > > test/integration/component/test_vpc_network.py 1d0b2d2 > > Diff: https://reviews.apache.org/r/14426/diff/ > > > Testing > ------- > > Tested script locally. Long running script... Latest run looks good so far. > > output so far: > Test create network in VPC ... ok > Test create network in VPC ... ok > Test create network in VPC mismatched services (Should fail) ... ok > Test create network in VPC mismatched services (Should fail) ... ok > Test create multiple networks with LB service (Should fail) ... ok > Test create multiple networks with LB service (Should fail) ... ok > Test create network with external LB devices ... ok > Test create network with redundant router capability ... SKIP: skipped - RvR > didn't support VPC currently > Test create network services not supported by VPC (Should fail) ... ok > Test create network without sourceNAT service in VPC (should fail) ... ok > Test create network with shared network offering ... ok > Test create network with shared network offering ... ok > Test create network with conserve mode ON ... ok > Test create network with conserve mode ON ... ok > Test network gc after shutdown of vms in the network ... FAIL > Test network rules after starting a VpcVr that was shutdown after network.gc > ... ok > Test Stop all the Vms that are part of the a Network ... ok > Test create network outside cidr range of VPC ... ok > Test create network outside cidr range of VPC ... ok > Test create network outside cidr range of VPC ... ok > Test create network inside cidr range of VPC ... ok > Test create network inside cidr range of VPC ... ok > Test create network overlapping cidr range of VPC ... > > > Thanks, > > Sowmya Krishnan > >
