----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14459/#review27597 -----------------------------------------------------------
test/integration/component/test_base_image_updation.py <https://reviews.apache.org/r/14459/#comment53627> Please add more detailed doc strings or comments about this feature. This will help to understand the test feature more. test/integration/component/test_base_image_updation.py <https://reviews.apache.org/r/14459/#comment53628> Not clear as what we are trying to achieve. There is a timeout, we slept for five seconds, then reducing the timeout by one second? How is the variable list_template_response accessible outside of while scope? Can we please initialize it? test/integration/component/test_base_image_updation.py <https://reviews.apache.org/r/14459/#comment53629> Combine these two checks of list existence and length in to one. Currently we are having multiple lines, instead we can combine in to one single call, we have added a simple utility function for this check, please use that. Its under lib/commons.py test/integration/component/test_base_image_updation.py <https://reviews.apache.org/r/14459/#comment53630> Add an empty return here. test/integration/component/test_base_image_updation.py <https://reviews.apache.org/r/14459/#comment53619> what if vms is None and vms is empty list test/integration/component/test_base_image_updation.py <https://reviews.apache.org/r/14459/#comment53620> If vms is empty list, it will lead to exception and a script failure. test/integration/component/test_base_image_updation.py <https://reviews.apache.org/r/14459/#comment53622> Whats the use of this check? We are proceeding anyways even if its not a list. test/integration/component/test_base_image_updation.py <https://reviews.apache.org/r/14459/#comment53621> If hosts is empty list and we dont verify then that exception will be a script issue. If the list is empty , dont we see it as a bug? Ideally, we are verify the list type but not the list length. Also, why we are proceeding if its not a list. Is that true or required? test/integration/component/test_base_image_updation.py <https://reviews.apache.org/r/14459/#comment53631> Whats the purpose of this message, where are we waiting? test/integration/component/test_base_image_updation.py <https://reviews.apache.org/r/14459/#comment53632> Where is the return statement? test/integration/component/test_base_image_updation.py <https://reviews.apache.org/r/14459/#comment53624> Empty list check. test/integration/component/test_base_image_updation.py <https://reviews.apache.org/r/14459/#comment53623> Why do we need none check again when list check is already done. test/integration/component/test_base_image_updation.py <https://reviews.apache.org/r/14459/#comment53634> Add "RECURRING" work to codes.py. We have added this under marvin. test/integration/component/test_base_image_updation.py <https://reviews.apache.org/r/14459/#comment53635> We dont need an assertion here? test/integration/component/test_base_image_updation.py <https://reviews.apache.org/r/14459/#comment53633> Again, sleeping for 60 seconds, but decreasing timeout only by one second. test/integration/component/test_base_image_updation.py <https://reviews.apache.org/r/14459/#comment53626> We verified the check inside the while loop, why do we need to check again here. Also, the scope of snapshots variable is inside the while loop, how we are getting the scope of that variable here outside of while loop - Santhosh Edukulla On Oct. 28, 2013, 6:02 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14459/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2013, 6:02 a.m.) > > > Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-2243 > https://issues.apache.org/jira/browse/CLOUDSTACK-2243 > > > Repository: cloudstack-git > > > Description > ------- > > Added new test class to test Base Image Updation Facility. > > > Diffs > ----- > > test/integration/component/test_base_image_updation.py PRE-CREATION > tools/marvin/marvin/integration/lib/base.py 4f15137 > > Diff: https://reviews.apache.org/r/14459/diff/ > > > Testing > ------- > > Tested locally on KVM advanced setup: > > Log: > > ==> result.log <== > test_01_deploy_instance_with_is_volatile_offering > (test_base_image_updation.TestBaseImageUpdate) > Test deploy an instance with service offerings with IsVolatile set. ... ok > test_02_reboot_instance_with_is_volatile_offering > (test_base_image_updation.TestBaseImageUpdate) > Test rebooting instances created with isVolatile service offerings ... > ==> client.log <== > 2013-10-09 20:22:30,659 - DEBUG - > test_02_reboot_instance_with_is_volatile_offering > (test_base_image_updation.TestBaseImageUpdate) - Checking root > th isVolatile=True > 2013-10-09 20:22:30,695 - DEBUG - > test_02_reboot_instance_with_is_volatile_offering > (test_base_image_updation.TestBaseImageUpdate) - Checking root > th isVolatile=False > > ==> result.log <== > ok > test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) > Test restoring a vm with different template than the one it was created with > ... > ==> client.log <== > 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo > ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0 > 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem > : 5a9190a9-8a59-487f-b90f-4a76a0f509a0 > 2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM > le=True > 2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM > le=False > 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot > po > disk on vm created with IsVolatile=True > 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : > HOURL > inute : 53 > 2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till > t > snapshoted > > ==> result.log <== > ok > test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) ... > ==> client.log <== > 2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of > atile=True was destroyed > 2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot > rule > isVolatile=True was destroyed > > ==> result.log <== > ok > > ---------------------------------------------------------------------- > Ran 4 tests in 3534.241s > > OK > > > Thanks, > > Ashutosh Kelkar > >
