> On Oct. 30, 2013, 1:59 p.m., Santhosh Edukulla wrote: > > test/integration/component/test_base_image_updation.py, line 411 > > <https://reviews.apache.org/r/14459/diff/4/?file=373887#file373887line411> > > > > I mean why not we assert at 407? Does self.fail is same as test case > > failure or product bug or is it different?
Agree. I have now put an assert at 407. > On Oct. 30, 2013, 1:59 p.m., Santhosh Edukulla wrote: > > test/integration/component/test_base_image_updation.py, line 602 > > <https://reviews.apache.org/r/14459/diff/4/?file=373887#file373887line602> > > > > but where we are failing the test case here? I mean its better to fail > > the test case instead of raising exception. What does it is of significance > > when exception is raised? what is the outcome of raising exception? Will > > the test case be falling in fail\error state? Changed it to self.fail. The test case should fail in this case if we don't get the list of snapshots. Going forward Exception should signify test script issues, in this case test case result states error. While self.fail signifies a product bug/ setup issue or other CS issue, we can't really say what it is, but this results in failure and not error state. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14459/#review27772 ----------------------------------------------------------- On Oct. 30, 2013, 4:56 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14459/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2013, 4:56 a.m.) > > > Review request for cloudstack, Girish Shilamkar and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-2243 > https://issues.apache.org/jira/browse/CLOUDSTACK-2243 > > > Repository: cloudstack-git > > > Description > ------- > > Added new test class to test Base Image Updation Facility. > > > Diffs > ----- > > test/integration/component/test_base_image_updation.py PRE-CREATION > tools/marvin/marvin/codes.py 3da90d6 > tools/marvin/marvin/integration/lib/base.py 4f15137 > > Diff: https://reviews.apache.org/r/14459/diff/ > > > Testing > ------- > > Tested locally on KVM advanced setup: > > Log: > > ==> result.log <== > test_01_deploy_instance_with_is_volatile_offering > (test_base_image_updation.TestBaseImageUpdate) > Test deploy an instance with service offerings with IsVolatile set. ... ok > test_02_reboot_instance_with_is_volatile_offering > (test_base_image_updation.TestBaseImageUpdate) > Test rebooting instances created with isVolatile service offerings ... > ==> client.log <== > 2013-10-09 20:22:30,659 - DEBUG - > test_02_reboot_instance_with_is_volatile_offering > (test_base_image_updation.TestBaseImageUpdate) - Checking root > th isVolatile=True > 2013-10-09 20:22:30,695 - DEBUG - > test_02_reboot_instance_with_is_volatile_offering > (test_base_image_updation.TestBaseImageUpdate) - Checking root > th isVolatile=False > > ==> result.log <== > ok > test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) > Test restoring a vm with different template than the one it was created with > ... > ==> client.log <== > 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) - Registered a template of fo > ith ID: 5a9190a9-8a59-487f-b90f-4a76a0f509a0 > 2013-10-09 20:22:32,373 - DEBUG - test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) - Waiting for download of tem > : 5a9190a9-8a59-487f-b90f-4a76a0f509a0 > 2013-10-09 20:38:25,367 - DEBUG - test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM > le=True > 2013-10-09 20:38:25,386 - DEBUG - test_03_restore_vm_with_new_template > (test_base_image_updation.TestBaseImageUpdate) - Checking template id of VM > le=False > 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Creating recurring snapshot > po > disk on vm created with IsVolatile=True > 2013-10-09 20:38:30,541 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Snapshot Policy - Type : > HOURL > inute : 53 > 2013-10-09 20:38:30,982 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Sleeping for 25 minutes till > t > snapshoted > > ==> result.log <== > ok > test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) ... > ==> client.log <== > 2013-10-09 21:11:51,780 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Checking whether root disk of > atile=True was destroyed > 2013-10-09 21:11:51,827 - DEBUG - test_04_reoccuring_snapshot_rules > (test_base_image_updation.TestBaseImageUpdate) - Checking whether snapshot > rule > isVolatile=True was destroyed > > ==> result.log <== > ok > > ---------------------------------------------------------------------- > Ran 4 tests in 3534.241s > > OK > > > Thanks, > > Ashutosh Kelkar > >
