> On Nov. 5, 2013, 9:43 a.m., Murali Reddy wrote: > > api/src/com/cloud/network/lb/LoadBalancingRule.java, lines 42-43 > > <https://reviews.apache.org/r/14976/diff/3/?file=374393#file374393line42> > > > > can you please add new constructors which takes ssl cert and protocol. > > If we extend same constructor then its resulting unnecessary changes in > > internal lb, elastic lb code as well.
I have added an new constructor and removed all reverted all the invocations in internal lb and elastic lb code. I am sorry but I am not aware of the difference between different LB types in cloudstack. Is there some place where I can find more info on this ? On Nov. 5, 2013, 9:43 a.m., Syed Ahmed wrote: > > - i dont see certificate details in the load balancer response obtained > > from listLoadBalancerRules.Does it make sense to give the certificate > > details if there is a cert assigined to load balancer rule? > > > > - i dont see code to add a network offering with > > 'SslTermination'capability. Also list network offering, should show if LB > > service with SSL termination is supported by the offering. > > > > - Please add Apache license header to all files. 1) I was looking at the listLoadBalancerRules API and it does not list other things bound to the lb rule like stickiness policy or health check policy so I assumed that SSL certs being something like health check will not be in the response. If it makes sense to add them, I will gladly do so. 2) So what you are saying is that Ssltermination will be a service offering like DNS, DHCP etc? Right now, if you see the NetscalerElement.java, I have just added the SslTermination capability as true. Does this suffice? 3) Done - Syed ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14976/#review28176 ----------------------------------------------------------- On Oct. 30, 2013, 8:34 p.m., Syed Ahmed wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14976/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2013, 8:34 p.m.) > > > Review request for cloudstack, Darren Shepherd, Murali Reddy, and Sheng Yang. > > > Bugs: CLOUDSTACK-4821 > https://issues.apache.org/jira/browse/CLOUDSTACK-4821 > > > Repository: cloudstack-git > > > Description > ------- > > This is the second patch for SSL termination support. This patch impletements > the assginement of certificate to loadbalancers. Support for netscaler is > also added. Due to the version of netscaler API in CS, I could not add > support for certificate chain. This should not be a big change however. We > can discuss this. > > > NOTE: Because I cannot diff with my local branch, this patch also includes > the first patch which includes certificate management logic ... sorry > > > Diffs > ----- > > api/src/com/cloud/agent/api/to/LoadBalancerTO.java df2f8a8 > api/src/com/cloud/event/EventTypes.java a762606 > api/src/com/cloud/network/Network.java 49f380b > api/src/com/cloud/network/lb/CertService.java PRE-CREATION > api/src/com/cloud/network/lb/LoadBalancingRule.java 4b37782 > api/src/com/cloud/network/lb/LoadBalancingRulesService.java 59d5c8d > api/src/com/cloud/network/lb/SslCert.java PRE-CREATION > api/src/org/apache/cloudstack/api/ApiConstants.java c75e6a0 > > api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignCertToLoadBalancerCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLoadBalancerRuleCmd.java > a368436 > > api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteSslCertCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListSslCertsCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/user/loadbalancer/RemoveCertFromLoadBalancerCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/user/loadbalancer/UploadSslCertCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/response/SslCertResponse.java > PRE-CREATION > client/tomcatconf/applicationContext.xml.in 2a3520b > client/tomcatconf/nonossComponentContext.xml.in 9d1da95 > core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java 3a51e8a > > engine/components-api/src/com/cloud/network/lb/LoadBalancingRulesManager.java > 3e32585 > engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapDao.java > PRE-CREATION > engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapDaoImpl.java > PRE-CREATION > engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapVO.java > PRE-CREATION > engine/schema/src/com/cloud/network/dao/LoadBalancerVO.java fee88cf > engine/schema/src/com/cloud/network/dao/SslCertDao.java PRE-CREATION > engine/schema/src/com/cloud/network/dao/SslCertDaoImpl.java PRE-CREATION > engine/schema/src/com/cloud/network/dao/SslCertVO.java PRE-CREATION > > plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java > ab414de > > plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java > b6269eb > > plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbelement/InternalLbElementTest.java > f170fee > > plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/InternalLBVMManagerTest.java > 82f90fb > > plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java > d63b14f > > plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java > fe072e1 > server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java > dd48930 > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java c685ee3 > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > 3dfcad5 > server/src/com/cloud/server/ManagementServerImpl.java 699f469 > > server/src/org/apache/cloudstack/network/lb/ApplicationLoadBalancerManagerImpl.java > 2385edc > server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java > PRE-CREATION > server/test/org/apache/cloudstack/lb/ApplicationLoadBalancerTest.java > 9b46e68 > > server/test/org/apache/cloudstack/network/lb/ApplicationLoadBalancerTest.java > PRE-CREATION > server/test/org/apache/cloudstack/network/lb/CertServiceTest.java > PRE-CREATION > server/test/resources/certs/bad_format_cert.crt PRE-CREATION > server/test/resources/certs/dsa_self_signed.crt PRE-CREATION > server/test/resources/certs/dsa_self_signed.key PRE-CREATION > server/test/resources/certs/expired_cert.crt PRE-CREATION > server/test/resources/certs/non_x509_pem.crt PRE-CREATION > server/test/resources/certs/root_chain.crt PRE-CREATION > server/test/resources/certs/rsa_ca_signed.crt PRE-CREATION > server/test/resources/certs/rsa_ca_signed.key PRE-CREATION > server/test/resources/certs/rsa_ca_signed2.crt PRE-CREATION > server/test/resources/certs/rsa_ca_signed2.key PRE-CREATION > server/test/resources/certs/rsa_random_pkey.key PRE-CREATION > server/test/resources/certs/rsa_self_signed.crt PRE-CREATION > server/test/resources/certs/rsa_self_signed.key PRE-CREATION > server/test/resources/certs/rsa_self_signed_with_pwd.crt PRE-CREATION > server/test/resources/certs/rsa_self_signed_with_pwd.key PRE-CREATION > setup/db/db/schema-421to430.sql aaebf96 > utils/src/com/cloud/utils/net/NetUtils.java f590425 > > Diff: https://reviews.apache.org/r/14976/diff/ > > > Testing > ------- > > Testing was done using a VPX on my setup. > > > Thanks, > > Syed Ahmed > >
