-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14976/
-----------------------------------------------------------
(Updated Nov. 6, 2013, 8:15 p.m.)
Review request for cloudstack, Darren Shepherd, Murali Reddy, and Sheng Yang.
Changes
-------
Final patch with the master.
Bugs: CLOUDSTACK-4821
https://issues.apache.org/jira/browse/CLOUDSTACK-4821
Repository: cloudstack-git
Description
-------
This is the second patch for SSL termination support. This patch impletements
the assginement of certificate to loadbalancers. Support for netscaler is also
added. Due to the version of netscaler API in CS, I could not add support for
certificate chain. This should not be a big change however. We can discuss this.
NOTE: Because I cannot diff with my local branch, this patch also includes the
first patch which includes certificate management logic ... sorry
Diffs (updated)
-----
CHANGES 054e7b0
api/src/com/cloud/agent/api/to/LoadBalancerTO.java df2f8a8
api/src/com/cloud/event/EventTypes.java d9f80eb
api/src/com/cloud/network/Network.java 318ac19
api/src/com/cloud/network/lb/CertService.java PRE-CREATION
api/src/com/cloud/network/lb/LoadBalancingRule.java 4b37782
api/src/com/cloud/network/lb/LoadBalancingRulesService.java 59d5c8d
api/src/com/cloud/network/lb/SslCert.java PRE-CREATION
api/src/org/apache/cloudstack/api/ApiConstants.java 3b2bc67
api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignCertToLoadBalancerCmd.java
PRE-CREATION
api/src/org/apache/cloudstack/api/command/user/loadbalancer/CreateLoadBalancerRuleCmd.java
a368436
api/src/org/apache/cloudstack/api/command/user/loadbalancer/DeleteSslCertCmd.java
PRE-CREATION
api/src/org/apache/cloudstack/api/command/user/loadbalancer/ListSslCertsCmd.java
PRE-CREATION
api/src/org/apache/cloudstack/api/command/user/loadbalancer/RemoveCertFromLoadBalancerCmd.java
PRE-CREATION
api/src/org/apache/cloudstack/api/command/user/loadbalancer/UploadSslCertCmd.java
PRE-CREATION
api/src/org/apache/cloudstack/api/response/SslCertResponse.java PRE-CREATION
client/tomcatconf/commands.properties.in 087d8b9
core/src/com/cloud/agent/api/routing/LoadBalancerConfigCommand.java 3a51e8a
engine/components-api/src/com/cloud/network/lb/LoadBalancingRulesManager.java
3e32585
engine/schema/resources/META-INF/cloudstack/core/spring-engine-schema-core-daos-context.xml
98ef018
engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapDao.java
PRE-CREATION
engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapDaoImpl.java
PRE-CREATION
engine/schema/src/com/cloud/network/dao/LoadBalancerCertMapVO.java
PRE-CREATION
engine/schema/src/com/cloud/network/dao/LoadBalancerVO.java fee88cf
engine/schema/src/com/cloud/network/dao/SslCertDao.java PRE-CREATION
engine/schema/src/com/cloud/network/dao/SslCertDaoImpl.java PRE-CREATION
engine/schema/src/com/cloud/network/dao/SslCertVO.java PRE-CREATION
plugins/network-elements/elastic-loadbalancer/src/com/cloud/network/lb/ElasticLoadBalancerManagerImpl.java
5c6f2e7
plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManagerImpl.java
b6269eb
plugins/network-elements/internal-loadbalancer/test/org/apache/cloudstack/internallbvmmgr/InternalLBVMManagerTest.java
82f90fb
plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
8101864
plugins/network-elements/netscaler/src/com/cloud/network/resource/NetscalerResource.java
fe072e1
server/resources/META-INF/cloudstack/core/spring-server-core-managers-context.xml
5e37908
server/src/com/cloud/network/ExternalLoadBalancerDeviceManagerImpl.java
6ca40c0
server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 0d43478
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
9b35a4b
server/src/com/cloud/server/ManagementServerImpl.java 79b20d0
server/src/org/apache/cloudstack/network/lb/ApplicationLoadBalancerManagerImpl.java
b7cd231
server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java PRE-CREATION
server/test/org/apache/cloudstack/lb/ApplicationLoadBalancerTest.java 9b46e68
server/test/org/apache/cloudstack/network/lb/ApplicationLoadBalancerTest.java
PRE-CREATION
server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
PRE-CREATION
server/test/resources/certs/bad_format_cert.crt PRE-CREATION
server/test/resources/certs/dsa_self_signed.crt PRE-CREATION
server/test/resources/certs/dsa_self_signed.key PRE-CREATION
server/test/resources/certs/expired_cert.crt PRE-CREATION
server/test/resources/certs/non_x509_pem.crt PRE-CREATION
server/test/resources/certs/root_chain.crt PRE-CREATION
server/test/resources/certs/rsa_ca_signed.crt PRE-CREATION
server/test/resources/certs/rsa_ca_signed.key PRE-CREATION
server/test/resources/certs/rsa_ca_signed2.crt PRE-CREATION
server/test/resources/certs/rsa_ca_signed2.key PRE-CREATION
server/test/resources/certs/rsa_random_pkey.key PRE-CREATION
server/test/resources/certs/rsa_self_signed.crt PRE-CREATION
server/test/resources/certs/rsa_self_signed.key PRE-CREATION
server/test/resources/certs/rsa_self_signed_with_pwd.crt PRE-CREATION
server/test/resources/certs/rsa_self_signed_with_pwd.key PRE-CREATION
setup/db/db/schema-421to430.sql 26e4abf
utils/src/com/cloud/utils/net/NetUtils.java f590425
Diff: https://reviews.apache.org/r/14976/diff/
Testing
-------
Testing was done using a VPX on my setup.
Thanks,
Syed Ahmed
