----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15304/#review28364 -----------------------------------------------------------
I'm not sure this is a good idea. The install target doesn't actually install cloudstack. It "installs" the generated artifacts into the local maven repository, but it does't make any changes to the machine itself. Adding this install procedure would cause our compile phase to make actual changes to the developers machine. Especially with multiple versions this might cause unintended behavior. Especially as the versions numbering of Marvin is not inline with the cloudstack code base. tools/marvin/pom.xml <https://reviews.apache.org/r/15304/#comment55185> How do we ensure it also works for people that use easy_install instead of pip? - Hugo Trippaers On Nov. 7, 2013, 10:11 a.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15304/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2013, 10:11 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Bugs: CLOUDSTACK-5073 > https://issues.apache.org/jira/browse/CLOUDSTACK-5073 > > > Repository: cloudstack-git > > > Description > ------- > > Currently, we dont install the Marvin packages with default mvn install. As > part of this command currently, we just source > distribute the Marvin. For marvin,We assume user to have run its own > installation of packages post distribution. > This way, some times if any new addition of package changes happens, user has > to explicitly run installation of marvin. > If not installed,the changes are not available to tests and other code. With > this change, we package and > install them as well > > > Diffs > ----- > > tools/marvin/pom.xml 0869248 > > Diff: https://reviews.apache.org/r/15304/diff/ > > > Testing > ------- > > Tested that installation works post packaging > > > Thanks, > > Santhosh Edukulla > >
