----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15304/#review28367 -----------------------------------------------------------
I'm with Hugo on this. It's going to become harder to fit marvin's build, package and install phases into maven's lifecycle goals. The marvin.sync for that reason is maintained as a separate profile. Unfortunately, it's not in the path of the developer build and so not many use it. I think we can defer this change and later cleanly separate out marvin into its own pypi repo like cloudmonkey. Then users can simply do $ pip install cloudstack-marvin $ pip upgrade cloudstack-marvin This is a more clear instruction than mixing it with maven commands which I have never liked but had to facilitate in the past. - Prasanna Santhanam On Nov. 7, 2013, 10:11 a.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15304/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2013, 10:11 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Bugs: CLOUDSTACK-5073 > https://issues.apache.org/jira/browse/CLOUDSTACK-5073 > > > Repository: cloudstack-git > > > Description > ------- > > Currently, we dont install the Marvin packages with default mvn install. As > part of this command currently, we just source > distribute the Marvin. For marvin,We assume user to have run its own > installation of packages post distribution. > This way, some times if any new addition of package changes happens, user has > to explicitly run installation of marvin. > If not installed,the changes are not available to tests and other code. With > this change, we package and > install them as well > > > Diffs > ----- > > tools/marvin/pom.xml 0869248 > > Diff: https://reviews.apache.org/r/15304/diff/ > > > Testing > ------- > > Tested that installation works post packaging > > > Thanks, > > Santhosh Edukulla > >
