Sorry for confusion, in fact it's just for "community" information.
Because in the original thread, I don't see the new column limitation, then find it out in wiki. Thanks for reformatting Alex! --Sheng On Wed, Nov 20, 2013 at 1:39 PM, Alex Huang <alex.hu...@citrix.com> wrote: > Sorry. What do you mean. Do you mean I did it wrong somehow and the > files are now over 180 columns wide? > > --Alex > > > -----Original Message----- > > From: Sheng Yang [mailto:sh...@yasker.org] > > Sent: Wednesday, November 20, 2013 9:43 AM > > To: <dev@cloudstack.apache.org> > > Subject: Re: [MERGE] Reformat of the source code.... > > > > FYI: > > > > coding convention at: > > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Coding+conventi > > ons > > > > The updated column limit is: "File content must be kept within 180 > columns" > > > > --Sheng > > > > > > On Wed, Nov 20, 2013 at 7:46 AM, Alex Huang <alex.hu...@citrix.com> > > wrote: > > > > > The branch is called reformat if you like to check it. > > > > > > --Alex > > > > > > > -----Original Message----- > > > > From: Alex Huang [mailto:alex.hu...@citrix.com] > > > > Sent: Wednesday, November 20, 2013 7:15 AM > > > > To: dev@cloudstack.apache.org > > > > Subject: [MERGE] Reformat of the source code.... > > > > > > > > Taking advantage of the CCC happening and 4.3 just being branched, I > did > > > a > > > > reformat of the entire source base. It converts all tabs to spaces > and > > > rejoin > > > > lines that were split due to the 80 column limit. I also added > > > checkstyle to > > > > maven build. There may be things missing here and there but overall > > > should > > > > reduce the number of lines in our checkins. > > > > > > > > It created a massive amount of change of course but it all compiles > and > > > starts > > > > up. Any concerns about met checking this in to master? I'll wait 24 > > > hours for > > > > this merge request since we've talked about this before. > > > > > > > > --Alex > > > >
