> On Nov. 26, 2013, 6:27 p.m., Nitin Mehta wrote: > > api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java, > > line 63 > > <https://reviews.apache.org/r/15832/diff/3/?file=391144#file391144line63> > > > > All this is boilerplate code. Have an abstract class and make all these > > classes extend this abstract class. There are some examples to get an idea > > for doing this.
Hi Nitin, The scalevm, scalesystemvm, upgradesystemvm and upgradevm all have similar API parameters. we need to move all these into a base class. I have created a bug for this. https://issues.apache.org/jira/browse/CLOUDSTACK-5286. > On Nov. 26, 2013, 6:27 p.m., Nitin Mehta wrote: > > server/src/com/cloud/vm/UserVmManagerImpl.java, line 812 > > <https://reviews.apache.org/r/15832/diff/3/?file=391157#file391157line812> > > > > I would suggest writing a util function for adding and removing these > > details. I think it can be used while deploying vm as well. Added functions saveCusotmOfferingDetails and removeCustomOfferingDetails. > On Nov. 26, 2013, 6:27 p.m., Nitin Mehta wrote: > > server/src/com/cloud/vm/UserVmManagerImpl.java, line 866 > > <https://reviews.apache.org/r/15832/diff/3/?file=391157#file391157line866> > > > > can you please break it down ? or write comments please Added a comment. > On Nov. 26, 2013, 6:27 p.m., Nitin Mehta wrote: > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java, line 1938 > > <https://reviews.apache.org/r/15832/diff/3/?file=391154#file391154line1938> > > > > check for !(cpuNumber == null && cpuSpeed == null && memory == null) > > > > Hi Nitin, the intention is to check if any one of the params (cpu men etc) is null then all should be null. - bharat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15832/#review29445 ----------------------------------------------------------- On Nov. 27, 2013, 9:33 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15832/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 9:33 a.m.) > > > Review request for cloudstack and Koushik Das. > > > Bugs: CLOUDSTACK-5161 > https://issues.apache.org/jira/browse/CLOUDSTACK-5161 > > > Repository: cloudstack-git > > > Description > ------- > > enable scaling of a vm using custom offering > CLOUDSTACK-5161 > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/ApiConstants.java 6f919c1 > > api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java > a7c864d > > api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java > 1357a7d > api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 6cb49c1 > api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java 3dfcdf9 > api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java > 7ec739e > engine/api/src/com/cloud/vm/VirtualMachineManager.java c78942f > engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java > 3a3de70 > engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f1f97fc > engine/schema/src/com/cloud/usage/UsageVMInstanceVO.java 06a7bee > framework/db/src/com/cloud/utils/db/GenericDaoBase.java 8e6f6a4 > server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java 4f351eb > server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 2260e1e > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3770eb8 > server/src/com/cloud/server/ManagementServerImpl.java d34da4f > server/src/com/cloud/vm/UserVmManager.java b7b4bd5 > server/src/com/cloud/vm/UserVmManagerImpl.java 00d8063 > server/test/com/cloud/vm/UserVmManagerTest.java 71bbebe > > Diff: https://reviews.apache.org/r/15832/diff/ > > > Testing > ------- > > Tested on master. > > > Thanks, > > bharat kumar > >