----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15832/#review29479 -----------------------------------------------------------
engine/schema/src/com/cloud/usage/UsageVMInstanceVO.java <https://reviews.apache.org/r/15832/#comment56777> This is already there. check. Avoid duplicating the enum between cloud and usage db. framework/db/src/com/cloud/utils/db/GenericDaoBase.java <https://reviews.apache.org/r/15832/#comment56769> '\' got added in the name, will result in build errors. server/src/com/cloud/configuration/ConfigurationManagerImpl.java <https://reviews.apache.org/r/15832/#comment56770> Update the FS with this information. Fix typos in comments and exception messages. server/src/com/cloud/vm/UserVmManager.java <https://reviews.apache.org/r/15832/#comment56785> Why is this needed in the interface? server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/15832/#comment56783> Below I see some save/remove custom details methods? Shouldn't you just call those methods here? server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/15832/#comment56782> Why is there a dependency to UsageVMInstanceVO? Isn't that a table in usage server? server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/15832/#comment56778> There are 2 things happening here: validating custom parameters and updating service offering. Separate them into separate functions. If validation is successful then update service offering. server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/15832/#comment56779> remove this check as this is always called from internal code and custom parameters will be non null. server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/15832/#comment56780> This is also not required as custom parameter map cannot be null server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/15832/#comment56781> Put some comment to explain the logic server/src/com/cloud/vm/UserVmManagerImpl.java <https://reviews.apache.org/r/15832/#comment56784> I see the usage event publishing code getting repeated. Move them to a separate method. - Koushik Das On Nov. 27, 2013, 9:33 a.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15832/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2013, 9:33 a.m.) > > > Review request for cloudstack and Koushik Das. > > > Bugs: CLOUDSTACK-5161 > https://issues.apache.org/jira/browse/CLOUDSTACK-5161 > > > Repository: cloudstack-git > > > Description > ------- > > enable scaling of a vm using custom offering > CLOUDSTACK-5161 > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/ApiConstants.java 6f919c1 > > api/src/org/apache/cloudstack/api/command/admin/systemvm/ScaleSystemVMCmd.java > a7c864d > > api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java > 1357a7d > api/src/org/apache/cloudstack/api/command/user/vm/ScaleVMCmd.java 6cb49c1 > api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java 3dfcdf9 > api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java > 7ec739e > engine/api/src/com/cloud/vm/VirtualMachineManager.java c78942f > engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java > 3a3de70 > engine/schema/src/com/cloud/service/dao/ServiceOfferingDaoImpl.java f1f97fc > engine/schema/src/com/cloud/usage/UsageVMInstanceVO.java 06a7bee > framework/db/src/com/cloud/utils/db/GenericDaoBase.java 8e6f6a4 > server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java 4f351eb > server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 2260e1e > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 3770eb8 > server/src/com/cloud/server/ManagementServerImpl.java d34da4f > server/src/com/cloud/vm/UserVmManager.java b7b4bd5 > server/src/com/cloud/vm/UserVmManagerImpl.java 00d8063 > server/test/com/cloud/vm/UserVmManagerTest.java 71bbebe > > Diff: https://reviews.apache.org/r/15832/diff/ > > > Testing > ------- > > Tested on master. > > > Thanks, > > bharat kumar > >
