----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15922/#review29875 -----------------------------------------------------------
Ship it! Committed to 4.2, 4.3 and master. - Girish Shilamkar On Nov. 30, 2013, 6:27 p.m., Santhosh Edukulla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15922/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2013, 6:27 p.m.) > > > Review request for cloudstack and Girish Shilamkar. > > > Repository: cloudstack-git > > > Description > ------- > > Added few enhancements to marvin. > Added new module for Logging Facility to marvin. > Added new Init facility to marvin. > Currently, there are multiple ways we are doing logging > Removed few unwanted logging cases. > Removed few command line switch options for logging. > The new way of logging now provides consolidated logging > under one single folder timestamped under the configured > folder path. > Removed parsing configuration from deploydata center > Added parsing,start logging and deploy as part of init > Added new error handling facility to catch unknown exception from > test cases. Currently, lot of scripts are throwing unknown > exceptions, add a handler to plugin to dump them to a file > > ToDO: > Will do clean up in phase2 for this patch. > Separate deployDatacenter from creating test client. > Clean up configGenerator > > > Diffs > ----- > > setup/dev/advanced.cfg 216314f > tools/marvin/marvin/cloudstackConnection.py 23f81fb > tools/marvin/marvin/codes.py f409c7c > tools/marvin/marvin/configGenerator.py 631e40f > tools/marvin/marvin/deployDataCenter.py 3f7eebb > tools/marvin/marvin/marvinInit.py PRE-CREATION > tools/marvin/marvin/marvinLog.py PRE-CREATION > tools/marvin/marvin/marvinPlugin.py 0e52bab > > Diff: https://reviews.apache.org/r/15922/diff/ > > > Testing > ------- > > Tested locally. Ran smoke tests. As well, run deploydatacenter separately to > check deployement is working fine. > > > Thanks, > > Santhosh Edukulla > >
